From: Akinobu Mita <akinobu.mita@gmail.com>
To: linux-scsi@vger.kernel.org
Cc: Akinobu Mita <akinobu.mita@gmail.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
"James E.J. Bottomley" <JBottomley@parallels.com>,
Christoph Hellwig <hch@lst.de>,
Dolev Raviv <draviv@codeaurora.org>,
Sujit Reddy Thumma <sthumma@codeaurora.org>,
Subhash Jadavani <subhashj@codeaurora.org>,
Hannes Reinecke <hare@suse.de>,
Sahitya Tummala <stummala@codeaurora.org>
Subject: [PATCH v2 1/6] scsi: ufs: avoid using hostdata after scsi_host_put()
Date: Sun, 2 Aug 2015 02:19:15 +0900 [thread overview]
Message-ID: <1438449560-4106-2-git-send-email-akinobu.mita@gmail.com> (raw)
In-Reply-To: <1438449560-4106-1-git-send-email-akinobu.mita@gmail.com>
The hostdata array, which is denoted by 'hba' in ufs driver, should
not be accessed after calling scsi_host_put().
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
Cc: Vinayak Holikatti <vinholikatti@gmail.com>
Cc: "James E.J. Bottomley" <JBottomley@parallels.com>
Cc: Christoph Hellwig <hch@lst.de>
Cc: Dolev Raviv <draviv@codeaurora.org>
Cc: Sujit Reddy Thumma <sthumma@codeaurora.org>
Cc: Subhash Jadavani <subhashj@codeaurora.org>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Sahitya Tummala <stummala@codeaurora.org>
Cc: linux-scsi@vger.kernel.org
---
drivers/scsi/ufs/ufshcd.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index b0ade73..e25f919 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -5363,12 +5363,12 @@ void ufshcd_remove(struct ufs_hba *hba)
ufshcd_disable_intr(hba, hba->intr_mask);
ufshcd_hba_stop(hba);
- scsi_host_put(hba->host);
-
ufshcd_exit_clk_gating(hba);
if (ufshcd_is_clkscaling_enabled(hba))
devfreq_remove_device(hba->devfreq);
ufshcd_hba_exit(hba);
+
+ scsi_host_put(hba->host);
}
EXPORT_SYMBOL_GPL(ufshcd_remove);
@@ -5671,9 +5671,9 @@ exit_gating:
ufshcd_exit_clk_gating(hba);
out_disable:
hba->is_irq_enabled = false;
- scsi_host_put(host);
ufshcd_hba_exit(hba);
out_error:
+ scsi_host_put(host);
return err;
}
EXPORT_SYMBOL_GPL(ufshcd_init);
--
1.9.1
next prev parent reply other threads:[~2015-08-01 17:19 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-01 17:19 [PATCH v2 0/6] scsi: ufs: fix several issues caused by driver reloading Akinobu Mita
2015-08-01 17:19 ` Akinobu Mita [this message]
2015-08-01 17:19 ` [PATCH v2 2/6] scsi: ufs: fix unbalanced power.usage_count after reloading driver Akinobu Mita
2015-08-01 17:19 ` [PATCH v2 3/6] scsi: ufs: fix unbalanced power.disable_depth " Akinobu Mita
2015-08-01 17:19 ` [PATCH v2 4/6] scsi: ufs: prevent IRQ handler accessing already freed hostdata Akinobu Mita
2015-08-01 17:19 ` [PATCH v2 5/6] scsi: ufs: fix unloading module while runtime suspended Akinobu Mita
2015-08-01 17:19 ` [PATCH v2 6/6] scsi: ufs: fix module reference for scsi host Akinobu Mita
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438449560-4106-2-git-send-email-akinobu.mita@gmail.com \
--to=akinobu.mita@gmail.com \
--cc=JBottomley@parallels.com \
--cc=draviv@codeaurora.org \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=sthumma@codeaurora.org \
--cc=stummala@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).