From: Tomer Barletz <barletz@gmail.com>
To: jayamohan.kallickal@avagotech.com, minh.tran@avagotech.com,
sony.john-n@avagotech.com, JBottomley@odin.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
Tomer Barletz <barletz@gmail.com>
Subject: [PATCH] scsi/be2iscsi: Fix logical-not-parentheses compilation warning
Date: Tue, 4 Aug 2015 11:25:43 -0700 [thread overview]
Message-ID: <1438712743-5821-1-git-send-email-barletz@gmail.com> (raw)
In-Reply-To: <mqdy4hrts7e.fsf@c203.arch.suse.de>
This fixes the following warning seen with GCC v5.1:
warning: logical not is only applied to the left hand side of
comparison [-Wlogical-not-parentheses].
Signed-off-by: Tomer Barletz <barletz@gmail.com>
---
drivers/scsi/be2iscsi/be_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/be2iscsi/be_main.c b/drivers/scsi/be2iscsi/be_main.c
index 7a6dbfb..cf1908e 100644
--- a/drivers/scsi/be2iscsi/be_main.c
+++ b/drivers/scsi/be2iscsi/be_main.c
@@ -3184,7 +3184,7 @@ be_sgl_create_contiguous(void *virtual_address,
{
WARN_ON(!virtual_address);
WARN_ON(!physical_address);
- WARN_ON(!length > 0);
+ WARN_ON(length == 0);
WARN_ON(!sgl);
sgl->va = virtual_address;
--
2.4.3
next prev parent reply other threads:[~2015-08-04 18:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-03 22:35 [PATCH] scsi/be2iscsi: Fix logical-not-parentheses compilation warning Tomer Barletz
2015-08-04 7:42 ` Johannes Thumshirn
2015-08-04 18:25 ` Tomer Barletz [this message]
2015-08-07 9:44 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1438712743-5821-1-git-send-email-barletz@gmail.com \
--to=barletz@gmail.com \
--cc=JBottomley@odin.com \
--cc=jayamohan.kallickal@avagotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=minh.tran@avagotech.com \
--cc=sony.john-n@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).