public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Axtens <dja@axtens.net>
To: "Matthew R. Ochs" <mrochs@linux.vnet.ibm.com>
Cc: linux-scsi@vger.kernel.org,
	James.Bottomley@HansenPartnership.com, nab@linux-iscsi.org,
	brking@linux.vnet.ibm.com, wenxiong@linux.vnet.ibm.com,
	hch@infradead.org, mikey@neuling.org, imunsie@au1.ibm.com,
	"Manoj N. Kumar" <manoj@linux.vnet.ibm.com>
Subject: Re: [PATCH v4 1/3] cxlflash: Base error recovery support
Date: Tue, 11 Aug 2015 20:58:25 +1000	[thread overview]
Message-ID: <1439290705.24419.30.camel@axtens.net> (raw)
In-Reply-To: <1439274073.24419.25.camel@axtens.net>

[-- Attachment #1: Type: text/plain, Size: 577 bytes --]

On Tue, 2015-08-11 at 16:21 +1000, Daniel Axtens wrote:
> Actually, I forgot one thing:
> 
> >  
> >  config CXLFLASH
> >  	tristate "Support for IBM CAPI Flash"
> > -	depends on PCI && SCSI && CXL
> > +	depends on PCI && SCSI && CXL && EEH
> 
> Should you depend on CXL_EEH here, seeing as you use CONFIG_CXL_EEH?
> 
Actually, never mind, I'm wrong. What you have is good.

> >  
> > +#ifndef CONFIG_CXL_EEH
> > +#define cxl_perst_reloads_same_image(_a, _b) do { } while (0)
> > +#endif
> > +
> >  #endif /* _CXLFLASH_MAIN_H */
> 

-- 
Regards,
Daniel

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 860 bytes --]

  reply	other threads:[~2015-08-11 11:00 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-10 17:09 [PATCH v4 1/3] cxlflash: Base error recovery support Matthew R. Ochs
2015-08-10 23:52 ` Daniel Axtens
2015-08-11 14:17   ` Matthew R. Ochs
2015-08-11  2:05 ` Michael Neuling
2015-08-11 21:40   ` Matthew R. Ochs
2015-08-11  3:41 ` Benjamin Herrenschmidt
2015-08-11 21:45   ` Matthew R. Ochs
2015-08-11  6:21 ` Daniel Axtens
2015-08-11 10:58   ` Daniel Axtens [this message]
2015-08-12  4:15 ` wenxiong
2015-08-12 17:00   ` Matthew R. Ochs

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1439290705.24419.30.camel@axtens.net \
    --to=dja@axtens.net \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=brking@linux.vnet.ibm.com \
    --cc=hch@infradead.org \
    --cc=imunsie@au1.ibm.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=manoj@linux.vnet.ibm.com \
    --cc=mikey@neuling.org \
    --cc=mrochs@linux.vnet.ibm.com \
    --cc=nab@linux-iscsi.org \
    --cc=wenxiong@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox