From: Tomas Henzl <thenzl@redhat.com>
To: linux-scsi@vger.kernel.org
Cc: kashyap.desai@avagotech.com, kiran-kumar.kasturi@avagotech.com,
Sumit.Saxena@avagotech.com
Subject: [PATCH] megaraid_sas: init tasklet earlier
Date: Tue, 25 Aug 2015 15:31:47 +0200 [thread overview]
Message-ID: <1440509507-3337-1-git-send-email-thenzl@redhat.com> (raw)
It may happen (kdump), that an interrupt is invoked just
after the setup_irqs function was called but before
the tasklet was initialised.
At this phase the hw ints should have been disabled, but for
unknown reason this mechanism seems to not work properly.
Signed-off-by: Tomas Henzl <thenzl@redhat.com>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 71b884dae2..c8e0c6de80 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -4627,6 +4627,9 @@ static int megasas_init_fw(struct megasas_instance *instance)
"current msix/online cpus\t: (%d/%d)\n",
instance->msix_vectors, (unsigned int)num_online_cpus());
+ tasklet_init(&instance->isr_tasklet, instance->instancet->tasklet,
+ (unsigned long)instance);
+
if (instance->msix_vectors ?
megasas_setup_irqs_msix(instance, 1) :
megasas_setup_irqs_ioapic(instance))
@@ -4647,9 +4650,6 @@ static int megasas_init_fw(struct megasas_instance *instance)
if (instance->instancet->init_adapter(instance))
goto fail_init_adapter;
- tasklet_init(&instance->isr_tasklet, instance->instancet->tasklet,
- (unsigned long)instance);
-
instance->instancet->enable_intr(instance);
printk(KERN_ERR "megasas: INIT adapter done\n");
--
2.4.3
next reply other threads:[~2015-08-25 13:31 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-25 13:31 Tomas Henzl [this message]
2015-08-26 13:15 ` [PATCH] megaraid_sas: init tasklet earlier Sumit Saxena
2015-08-26 14:14 ` Tomas Henzl
2015-08-28 10:22 ` Sumit Saxena
2015-10-15 9:46 ` Sumit Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440509507-3337-1-git-send-email-thenzl@redhat.com \
--to=thenzl@redhat.com \
--cc=Sumit.Saxena@avagotech.com \
--cc=kashyap.desai@avagotech.com \
--cc=kiran-kumar.kasturi@avagotech.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).