From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Bjorn Helgaas <bhelgaas@google.com>
Cc: Kashyap Desai <kashyap.desai@avagotech.com>,
Uday Lingala <uday.lingala@avagotech.com>,
Sumit Saxena <sumit.saxena@avagotech.com>,
megaraidlinux.pdl@avagotech.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org, Joe Perches <joe@perches.com>,
Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v3 3/3] megaraid_sas : fix whitespace errors
Date: Wed, 26 Aug 2015 07:36:30 -0700 [thread overview]
Message-ID: <1440599790.2196.9.camel@HansenPartnership.com> (raw)
In-Reply-To: <20150707205245.6218.59809.stgit@bhelgaas-glaptop2.roam.corp.google.com>
On Tue, 2015-07-07 at 15:52 -0500, Bjorn Helgaas wrote:
> Fix whitespace and indentation errors. No code change.
checkpatch says you missed one:
ERROR: space required after that ',' (ctx:VxV)
#860: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:6457:
+ if (sscanf(buf,"%u",&megasas_dbg_lvl) < 1) {
^
ERROR: space required after that ',' (ctx:VxO)
#860: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:6457:
+ if (sscanf(buf,"%u",&megasas_dbg_lvl) < 1) {
^
ERROR: space required before that '&' (ctx:OxV)
#860: FILE: drivers/scsi/megaraid/megaraid_sas_base.c:6457:
+ if (sscanf(buf,"%u",&megasas_dbg_lvl) < 1) {
I fixed it up
James
prev parent reply other threads:[~2015-08-26 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-07-07 20:52 [PATCH v3 0/3] megaraid: use dev_printk() when possible Bjorn Helgaas
2015-07-07 20:52 ` [PATCH v3 1/3] megaraid : use dev_printk " Bjorn Helgaas
2015-07-08 6:08 ` Sumit Saxena
2015-07-08 10:44 ` Hannes Reinecke
2015-07-07 20:52 ` [PATCH v3 2/3] megaraid_sas " Bjorn Helgaas
2015-07-08 9:13 ` Sumit Saxena
2015-07-08 10:47 ` Hannes Reinecke
2015-07-08 13:28 ` Bjorn Helgaas
2015-07-07 20:52 ` [PATCH v3 3/3] megaraid_sas : fix whitespace errors Bjorn Helgaas
2015-07-08 9:13 ` Sumit Saxena
2015-07-08 10:48 ` Hannes Reinecke
2015-08-26 14:36 ` James Bottomley [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440599790.2196.9.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=bhelgaas@google.com \
--cc=hch@lst.de \
--cc=joe@perches.com \
--cc=kashyap.desai@avagotech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=megaraidlinux.pdl@avagotech.com \
--cc=sumit.saxena@avagotech.com \
--cc=uday.lingala@avagotech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).