From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <james.bottomley@hansenpartnership.com>
Cc: Christoph Hellwig <hch@lst.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Bart van Assche <bart.vanassche@sandisk.com>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 16/23] scsi: Add scsi_vpd_lun_id()
Date: Thu, 27 Aug 2015 14:41:14 +0200 [thread overview]
Message-ID: <1440679281-13234-17-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1440679281-13234-1-git-send-email-hare@suse.de>
Add a function scsi_vpd_lun_id() to return a unique device
identifcation based on the designation descriptors of
VPD page 0x83.
As devices might implement several descriptors the order
of preference is:
- NAA IEE Registered Extended
- EUI-64 based 16-byte
- EUI-64 based 12-byte
- NAA IEEE Registered
- NAA IEEE Extended
A SCSI name string descriptor is preferred to all of them
if the identification is longer than 16 bytes.
The returned unique device identification will be formatted
as a SCSI Name string to avoid clashes between different
designator types.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/scsi_lib.c | 121 +++++++++++++++++++++++++++++++++++++++++++++
include/scsi/scsi_device.h | 1 +
2 files changed, 122 insertions(+)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index 2a864b8..48d6ff6 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -3145,3 +3145,124 @@ void sdev_enable_disk_events(struct scsi_device *sdev)
atomic_dec(&sdev->disk_events_disable_depth);
}
EXPORT_SYMBOL(sdev_enable_disk_events);
+
+/*
+ * scsi_vpd_lun_id - return a unique device identification
+ * @sdev: SCSI device
+ * @id: buffer for the identification
+ * @id_len: length of the buffer
+ *
+ * Copies a unique device identification into @id based
+ * on the information in the VPD page 0x83 of the device.
+ * The string will be formatted as a SCSI name string.
+ *
+ * Returns the length of the identification or error on failure.
+ */
+int scsi_vpd_lun_id(struct scsi_device *sdev, char *id, size_t id_len)
+{
+ u8 cur_id_type = 0xff;
+ u8 cur_id_size = 0;
+ unsigned char *d, *cur_id_str;
+ int id_size = -EAGAIN;
+
+ /*
+ * Look for the correct descriptor.
+ * Order of preference for lun descriptor:
+ * - SCSI name string
+ * - NAA IEEE Registered Extended
+ * - EUI-64 based 16-byte
+ * - EUI-64 based 12-byte
+ * - NAA IEEE Registered
+ * - NAA IEEE Extended
+ * as longer descriptors reduce the likelyhood
+ * of identification clashes.
+ */
+
+ /* The id string must be at least 20 bytes + terminating NULL byte */
+ if (id_len < 21)
+ return -EINVAL;
+
+ memset(id, 0, id_len);
+ d = sdev->vpd_pg83 + 4;
+ while (d < sdev->vpd_pg83 + sdev->vpd_pg83_len) {
+ /* Skip designators not referring to the LUN */
+ if ((d[1] & 0x30) != 0x00)
+ goto next_desig;
+
+ switch (d[1] & 0xf) {
+ case 0x2:
+ /* EUI-64 */
+ if (cur_id_size > d[3])
+ break;
+ /* Prefer NAA IEEE Registered Extended */
+ if (cur_id_type == 0x3 &&
+ cur_id_size == d[3])
+ break;
+ cur_id_size = d[3];
+ cur_id_str = d + 4;
+ cur_id_type = d[1] & 0xf;
+ switch (cur_id_size) {
+ case 8:
+ id_size = snprintf(id, id_len,
+ "eui.%8phN",
+ cur_id_str);
+ break;
+ case 12:
+ id_size = snprintf(id, id_len,
+ "eui.%12phN",
+ cur_id_str);
+ break;
+ case 16:
+ id_size = snprintf(id, id_len,
+ "eui.%16phN",
+ cur_id_str);
+ break;
+ default:
+ cur_id_size = 0;
+ break;
+ }
+ break;
+ case 0x3:
+ /* NAA */
+ if (cur_id_size > d[3])
+ break;
+ cur_id_size = d[3];
+ cur_id_str = d + 4;
+ cur_id_type = d[1] & 0xf;
+ switch (cur_id_size) {
+ case 8:
+ id_size = snprintf(id, id_len,
+ "naa.%8phN",
+ cur_id_str);
+ break;
+ case 16:
+ id_size = snprintf(id, id_len,
+ "naa.%16phN",
+ cur_id_str);
+ break;
+ default:
+ cur_id_size = 0;
+ break;
+ }
+ break;
+ case 0x8:
+ /* SCSI name string */
+ if (cur_id_size + 4 > d[3])
+ break;
+ cur_id_size = d[3];
+ cur_id_str = d + 4;
+ cur_id_type = d[1] & 0xf;
+ if (cur_id_size >= id_len)
+ cur_id_size = id_len - 1;
+ memcpy(id, cur_id_str, cur_id_size);
+ break;
+ default:
+ break;
+ }
+next_desig:
+ d += d[3] + 4;
+ }
+
+ return id_size;
+}
+EXPORT_SYMBOL(scsi_vpd_lun_id);
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index b6b1dc4..595a9be 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -413,6 +413,7 @@ static inline int scsi_execute_req(struct scsi_device *sdev,
}
extern void sdev_disable_disk_events(struct scsi_device *sdev);
extern void sdev_enable_disk_events(struct scsi_device *sdev);
+extern int scsi_vpd_lun_id(struct scsi_device *, char *, size_t);
#ifdef CONFIG_PM
extern int scsi_autopm_get_device(struct scsi_device *);
--
1.8.5.6
next prev parent reply other threads:[~2015-08-27 12:41 UTC|newest]
Thread overview: 93+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-27 12:40 [PATCHv4 00/23] asynchronous ALUA device handler Hannes Reinecke
2015-08-27 12:40 ` [PATCH 01/23] scsi_dh_alua: Disable ALUA handling for non-disk devices Hannes Reinecke
2015-09-01 9:37 ` Christoph Hellwig
2015-09-04 3:36 ` Martin K. Petersen
2015-09-22 18:28 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 02/23] scsi_dh_alua: Use vpd_pg83 information Hannes Reinecke
2015-09-04 3:37 ` Martin K. Petersen
2015-09-22 18:29 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 03/23] scsi_dh_alua: improved logging Hannes Reinecke
2015-09-04 3:38 ` Martin K. Petersen
2015-09-22 18:30 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 04/23] scsi_dh_alua: use standard logging functions Hannes Reinecke
2015-09-01 9:48 ` Christoph Hellwig
2015-09-01 12:39 ` Hannes Reinecke
2015-09-22 18:32 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 05/23] scsi_dh_alua: return standard SCSI return codes in submit_rtpg Hannes Reinecke
2015-09-01 9:52 ` Christoph Hellwig
2015-09-22 18:34 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 06/23] scsi_dh_alua: fixup description of stpg_endio() Hannes Reinecke
2015-09-01 9:52 ` Christoph Hellwig
2015-09-04 3:40 ` Martin K. Petersen
2015-09-22 18:36 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 07/23] scsi: remove scsi_show_sense_hdr() Hannes Reinecke
2015-09-04 3:41 ` Martin K. Petersen
2015-09-22 18:36 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 08/23] scsi_dh_alua: use flag for RTPG extended header Hannes Reinecke
2015-09-04 3:42 ` Martin K. Petersen
2015-09-22 18:37 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 09/23] scsi_dh_alua: use unaligned access macros Hannes Reinecke
2015-09-01 9:53 ` Christoph Hellwig
2015-09-04 3:43 ` Martin K. Petersen
2015-09-22 18:37 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 10/23] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2015-09-01 9:55 ` Christoph Hellwig
2015-09-04 3:44 ` Martin K. Petersen
2015-09-22 18:43 ` Ewan Milne
2015-09-24 16:37 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 11/23] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2015-09-01 10:04 ` Christoph Hellwig
2015-09-01 12:58 ` Hannes Reinecke
2015-09-22 18:50 ` Ewan Milne
2015-09-24 16:47 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 12/23] scsi_dh_alua: switch to scsi_execute_req_flags() Hannes Reinecke
2015-09-01 10:07 ` Christoph Hellwig
2015-09-22 18:54 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 13/23] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2015-09-01 10:20 ` Christoph Hellwig
2015-09-01 13:02 ` Hannes Reinecke
2015-09-01 13:44 ` Christoph Hellwig
2015-09-01 14:01 ` Hannes Reinecke
2015-09-01 10:48 ` Christoph Hellwig
2015-09-22 18:57 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 14/23] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2015-09-22 19:04 ` Ewan Milne
2015-09-24 17:19 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 15/23] scsi_dh_alua: simplify sense code handling Hannes Reinecke
2015-09-22 19:10 ` Ewan Milne
2015-09-28 6:41 ` Hannes Reinecke
2015-08-27 12:41 ` Hannes Reinecke [this message]
2015-09-01 10:22 ` [PATCH 16/23] scsi: Add scsi_vpd_lun_id() Christoph Hellwig
2015-09-01 12:43 ` Hannes Reinecke
2015-09-22 19:17 ` Ewan Milne
2015-09-28 7:18 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 17/23] scsi_dh_alua: use unique device id Hannes Reinecke
2015-09-01 10:25 ` Christoph Hellwig
2015-09-22 19:31 ` Ewan Milne
2015-09-28 7:41 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 18/23] revert "scsi_dh_alua: ALUA hander attach should succeed while TPG is transitioning" Hannes Reinecke
2015-09-22 19:34 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 19/23] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2015-09-01 11:15 ` Christoph Hellwig
2015-09-01 12:57 ` Hannes Reinecke
2015-09-02 6:39 ` Christoph Hellwig
2015-09-02 8:48 ` Hannes Reinecke
2015-11-05 20:34 ` Todd Gill
2015-09-22 19:49 ` Ewan Milne
2015-09-22 20:15 ` Hannes Reinecke
2015-09-23 13:58 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 20/23] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2015-09-01 10:31 ` Christoph Hellwig
2015-09-22 19:57 ` Ewan Milne
2015-09-23 13:01 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 21/23] scsi_dh_alua: update all port states Hannes Reinecke
2015-09-01 10:32 ` Christoph Hellwig
2015-09-22 20:04 ` Ewan Milne
2015-09-22 20:20 ` Hannes Reinecke
2015-08-27 12:41 ` [PATCH 22/23] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2015-09-01 10:34 ` Christoph Hellwig
2015-09-22 20:05 ` Ewan Milne
2015-08-27 12:41 ` [PATCH 23/23] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
2015-09-01 10:34 ` Christoph Hellwig
2015-09-22 20:05 ` Ewan Milne
2015-09-24 16:25 ` [PATCHv4 00/23] asynchronous ALUA device handler Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1440679281-13234-17-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).