From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ewan Milne Subject: Re: [scsi 5/7 RESEND] scsi_debug: schedule_resp fix input variable check Date: Thu, 27 Aug 2015 15:56:09 -0400 Message-ID: <1440705369.23183.142.camel@localhost.localdomain> References: <1438091666-18113-1-git-send-email-tomas.winkler@intel.com> <1438091666-18113-5-git-send-email-tomas.winkler@intel.com> <1440532371.23183.81.camel@localhost.localdomain> <5B8DA87D05A7694D9FA63FD143655C1B3D42E9D0@hasmsx108.ger.corp.intel.com> <1440632280.2196.94.camel@HansenPartnership.com> Reply-To: emilne@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: QUOTED-PRINTABLE Return-path: In-Reply-To: <1440632280.2196.94.camel@HansenPartnership.com> Sender: linux-kernel-owner@vger.kernel.org To: James Bottomley Cc: "Winkler, Tomas" , Christoph Hellwig , "linux-scsi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Douglas Gilbert List-Id: linux-scsi@vger.kernel.org On Wed, 2015-08-26 at 16:38 -0700, James Bottomley wrote: > On Tue, 2015-08-25 at 21:03 +0000, Winkler, Tomas wrote: > >=20 > > > > + /* this should never happen */ > > > > + if (WARN_ON(!cmnd)) > > > > + return SCSI_MLQUEUE_HOST_BUSY; > > > > > > > > - if (NULL =3D=3D cmnd || NULL =3D=3D devip) { > > > > - pr_warn("called with NULL cmnd or devip pointer\n"); > > > > + if (NULL =3D=3D devip) { > > > > + pr_warn("called devip =3D=3D NULL\n"); > > > > /* no particularly good error to report back */ > > > > return SCSI_MLQUEUE_HOST_BUSY; > > > > } > > >=20 > > > Please refer to the patch I just posted, we can't return _HOST_BU= SY here > > > if devip =3D=3D NULL. I posted a fix against the current "misc" = branch as > > > I don't see this patch applied, let me know if I need to update i= t. > >=20 > >=20 > > I'm just not sure why the patches are not merged or even rejected. >=20 > Because ideally I want a Maintainer ack. That's Doug Gilbert. >=20 > > I'm submitting patches to the Linux kernel for more than 10 years t= o > > various trees and I can agree that these are not some urgent fixe= s, > > but this is the first time my effort is ignored for such long time= by > > the maintainer.=20 >=20 > Well, OK, I trust martin, I'll override the lack of Maintainer ack if > you fix as Ewan suggests. >=20 Just to clarify, I didn't have a problem with Tomas' patch per se, it's just that my patch won't apply on top of his. I'll submit a v2 if you want, so you can apply Tomas' patch first. The problem I'm fixing has been in there for a while. Let me know if you want me to do that. -Ewan > James >=20 >=20 > > Thanks > > Tomas > >=20 > > NrybX=C7=A7v^)=DE=BA{.n+{"{ay=1D=CA=87=DA=99,j=07fhz=1Ew=0Cj:+vwjm=07= zZ+=DD=A2j"! >=20 >=20 >=20