public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Vitaly Kuznetsov <vkuznets@redhat.com>
To: "James E.J. Bottomley" <JBottomley@odin.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
	"K. Y. Srinivasan" <kys@microsoft.com>,
	Long Li <longli@microsoft.com>, Dexuan Cui <decui@microsoft.com>
Subject: [PATCH] scsi_scan: move 'INQUIRY result too short' message to debug level
Date: Mon, 31 Aug 2015 14:50:01 +0200	[thread overview]
Message-ID: <1441025401-30044-1-git-send-email-vkuznets@redhat.com> (raw)

Some Hyper-V hosts are known for ignoring SPC-2/3/4 requirement
for 'INQUIRY data (see table ...) shall contain at least 36 bytes'. As a
result we get tons on 'scsi 0:7:1:1: scsi scan: INQUIRY result too short
(5), using 36' messages on console. As Hyper-V is also known for its
serial port being extremely slow multi-VCPU guests we get CPU blocked
putting these (useless) messages on console (e.g. happens when we add
multiple disks). Move them to debug level.

Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
---
 drivers/scsi/scsi_scan.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index f9f3f82..cb5c50a 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -701,7 +701,7 @@ static int scsi_probe_lun(struct scsi_device *sdev, unsigned char *inq_result,
 	 * strings.
 	 */
 	if (sdev->inquiry_len < 36) {
-		sdev_printk(KERN_INFO, sdev,
+		sdev_printk(KERN_DEBUG, sdev,
 			    "scsi scan: INQUIRY result too short (%d),"
 			    " using 36\n", sdev->inquiry_len);
 		sdev->inquiry_len = 36;
-- 
2.4.3

             reply	other threads:[~2015-08-31 12:50 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 12:50 Vitaly Kuznetsov [this message]
2015-08-31 13:21 ` [PATCH] scsi_scan: move 'INQUIRY result too short' message to debug level KY Srinivasan
2015-09-01 13:49 ` James Bottomley
2015-09-01 15:43   ` Vitaly Kuznetsov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1441025401-30044-1-git-send-email-vkuznets@redhat.com \
    --to=vkuznets@redhat.com \
    --cc=JBottomley@odin.com \
    --cc=decui@microsoft.com \
    --cc=kys@microsoft.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=longli@microsoft.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox