From: Ewan Milne <emilne@redhat.com>
To: anil.gurumurthy@qlogic.com
Cc: James.Bottomley@HansenPartnership.com, hch@infradead.org,
linux-scsi@vger.kernel.org, sudarsana.kalluru@qlogic.com
Subject: Re: [PATCH 1/2] bfa: Fix indentation
Date: Thu, 03 Sep 2015 10:31:48 -0400 [thread overview]
Message-ID: <1441290708.23183.322.camel@localhost.localdomain> (raw)
In-Reply-To: <1439462512-1911-2-git-send-email-anil.gurumurthy@qlogic.com>
On Thu, 2015-08-13 at 06:41 -0400, anil.gurumurthy@qlogic.com wrote:
> From: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
>
> Signed-off-by: Anil Gurumurthy <anil.gurumurthy@qlogic.com>
> Tested-by : Sudarasana Kalluru <sudarsana.kalluru@qlogic.com>
> ---
> drivers/scsi/bfa/bfa_ioc.c | 22 +++++++++++-----------
> 1 file changed, 11 insertions(+), 11 deletions(-)
>
> diff --git a/drivers/scsi/bfa/bfa_ioc.c b/drivers/scsi/bfa/bfa_ioc.c
> index 315d6d6..4e71044 100644
> --- a/drivers/scsi/bfa/bfa_ioc.c
> +++ b/drivers/scsi/bfa/bfa_ioc.c
> @@ -3665,19 +3665,19 @@ bfa_cb_sfp_state_query(struct bfa_sfp_s *sfp)
> if (sfp->state_query_cbfn)
> sfp->state_query_cbfn(sfp->state_query_cbarg,
> sfp->status);
> - sfp->media = NULL;
> - }
> + sfp->media = NULL;
> + }
>
> - if (sfp->portspeed) {
> - sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
> - if (sfp->state_query_cbfn)
> - sfp->state_query_cbfn(sfp->state_query_cbarg,
> - sfp->status);
> - sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
> - }
> + if (sfp->portspeed) {
> + sfp->status = bfa_sfp_speed_valid(sfp, sfp->portspeed);
> + if (sfp->state_query_cbfn)
> + sfp->state_query_cbfn(sfp->state_query_cbarg,
> + sfp->status);
> + sfp->portspeed = BFA_PORT_SPEED_UNKNOWN;
> + }
>
> - sfp->state_query_lock = 0;
> - sfp->state_query_cbfn = NULL;
> + sfp->state_query_lock = 0;
> + sfp->state_query_cbfn = NULL;
> }
>
> /*
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
next prev parent reply other threads:[~2015-09-03 14:31 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-13 10:41 [PATCH 0/2] Patches for scsi "misc" branch anil.gurumurthy
2015-08-13 10:41 ` [PATCH 1/2] bfa: Fix indentation anil.gurumurthy
2015-09-03 14:31 ` Ewan Milne [this message]
2015-08-13 10:41 ` [PATCH 2/2] bfa: Fix incorrect de-reference of pointer anil.gurumurthy
2015-09-03 14:32 ` Ewan Milne
2015-08-28 19:09 ` [PATCH 0/2] Patches for scsi "misc" branch James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1441290708.23183.322.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=anil.gurumurthy@qlogic.com \
--cc=hch@infradead.org \
--cc=linux-scsi@vger.kernel.org \
--cc=sudarsana.kalluru@qlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).