public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: vasu.dev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org
Cc: fcoe-devel-s9riP+hp16TNLxjTenLetw@public.gmane.org,
	JBottomley-wo1vFcy6AUs@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: [PATCH] fcoe:Fix incorrect use of non wrapper version of skb_buff helper function in fcoe_percpu_recieve_thread
Date: Sun, 20 Sep 2015 18:22:39 -0400	[thread overview]
Message-ID: <1442787759-13033-1-git-send-email-xerofoify@gmail.com> (raw)

This fixes the incorrect use of the non wrapper version of the
function skb_dequeue in fcoe_percpu_receive_thread to use the
wrapper version as we need to protect avoid other users from
concurrently access on the sk_buff_head tmp used as the link
list head for this call to skb_queue.

Signed-off-by: Nicholas Krause <xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
 drivers/scsi/fcoe/fcoe.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
index d3eb80c..f89bd4c 100644
--- a/drivers/scsi/fcoe/fcoe.c
+++ b/drivers/scsi/fcoe/fcoe.c
@@ -1888,7 +1888,7 @@ retry:
 
 		spin_unlock_bh(&p->fcoe_rx_list.lock);
 
-		while ((skb = __skb_dequeue(&tmp)) != NULL)
+		while ((skb = skb_dequeue(&tmp)) != NULL)
 			fcoe_recv_frame(skb);
 
 	}
-- 
2.1.4

             reply	other threads:[~2015-09-20 22:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-09-20 22:22 Nicholas Krause [this message]
     [not found] ` <1442787759-13033-1-git-send-email-xerofoify-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2015-09-21 20:09   ` [PATCH] fcoe:Fix incorrect use of non wrapper version of skb_buff helper function in fcoe_percpu_recieve_thread Chris Leech

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1442787759-13033-1-git-send-email-xerofoify@gmail.com \
    --to=xerofoify-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=JBottomley-wo1vFcy6AUs@public.gmane.org \
    --cc=fcoe-devel-s9riP+hp16TNLxjTenLetw@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=vasu.dev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox