From: Hannes Reinecke <hare@suse.de>
To: James Bottomley <james.bottomley@hansenpartnership.com>
Cc: linux-scsi@vger.kernel.org, Christoph Hellwig <hch@lst.de>,
Bart van Assche <bart.vanassche@sandisk.com>,
Ewan Milne <emilne@redhat.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH 24/36] scsi: Add scsi_vpd_tpg_id()
Date: Tue, 29 Sep 2015 12:47:26 +0200 [thread overview]
Message-ID: <1443523658-87622-25-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1443523658-87622-1-git-send-email-hare@suse.de>
Implement scsi_vpd_tpg_id() to extract the target
port group id and the relative port id from
SCSI VPD page 0x83.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/scsi_lib.c | 42 ++++++++++++++++++++++++++++++++++++++++++
include/scsi/scsi_device.h | 1 +
2 files changed, 43 insertions(+)
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index de3dcef..fd4203c 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -23,6 +23,7 @@
#include <linux/scatterlist.h>
#include <linux/blk-mq.h>
#include <linux/ratelimit.h>
+#include <asm/unaligned.h>
#include <scsi/scsi.h>
#include <scsi/scsi_cmnd.h>
@@ -3286,3 +3287,44 @@ next_desig:
return id_size;
}
EXPORT_SYMBOL(scsi_vpd_lun_id);
+
+/*
+ * scsi_vpd_tpg_id - return a target port group identifier
+ * @sdev: SCSI device
+ *
+ * Returns the Target Port Group identifier from the information
+ * froom VPD page 0x83 of the device.
+ *
+ * Returns the identifier or error on failure.
+ */
+int scsi_vpd_tpg_id(struct scsi_device *sdev, int *rel_id)
+{
+ unsigned char *d;
+ int group_id = -EAGAIN, rel_port = -1;
+
+ if (!sdev->vpd_pg83)
+ return -ENXIO;
+
+ d = sdev->vpd_pg83 + 4;
+ while (d < sdev->vpd_pg83 + sdev->vpd_pg83_len) {
+ switch (d[1] & 0xf) {
+ case 0x4:
+ /* Relative target port */
+ rel_port = get_unaligned_be16(&d[6]);
+ break;
+ case 0x5:
+ /* Target port group */
+ group_id = get_unaligned_be16(&d[6]);
+ break;
+ default:
+ break;
+ }
+ d += d[3] + 4;
+ }
+
+ if (group_id >= 0 && rel_id && rel_port != -1)
+ *rel_id = rel_port;
+
+ return group_id;
+}
+EXPORT_SYMBOL(scsi_vpd_tpg_id);
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index 6a9e6b2..cc6e763 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -415,6 +415,7 @@ static inline int scsi_execute_req(struct scsi_device *sdev,
extern void sdev_disable_disk_events(struct scsi_device *sdev);
extern void sdev_enable_disk_events(struct scsi_device *sdev);
extern int scsi_vpd_lun_id(struct scsi_device *, char *, size_t);
+extern int scsi_vpd_tpg_id(struct scsi_device *, int *);
#ifdef CONFIG_PM
extern int scsi_autopm_get_device(struct scsi_device *);
--
1.8.5.6
next prev parent reply other threads:[~2015-09-29 10:47 UTC|newest]
Thread overview: 64+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-29 10:47 [PATCHv5 00/36] asynchronous ALUA device handler Hannes Reinecke
2015-09-29 10:47 ` [PATCH 01/36] scsi_dh: move 'dh_state' sysfs attribute to generic code Hannes Reinecke
2015-10-01 23:18 ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 02/36] scsi: ignore errors from scsi_dh_add_device() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 03/36] scsi_dh_alua: Disable ALUA handling for non-disk devices Hannes Reinecke
2015-09-29 10:47 ` [PATCH 04/36] scsi_dh_alua: Use vpd_pg83 information Hannes Reinecke
2015-09-29 10:47 ` [PATCH 05/36] scsi_dh_alua: improved logging Hannes Reinecke
2015-09-29 10:47 ` [PATCH 06/36] scsi_dh_alua: sanitze sense code handling Hannes Reinecke
2015-10-01 23:39 ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 07/36] scsi_dh_alua: use standard logging functions Hannes Reinecke
2015-10-01 23:50 ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 08/36] scsi_dh_alua: return standard SCSI return codes in submit_rtpg Hannes Reinecke
2015-10-01 23:58 ` Bart Van Assche
2015-10-02 6:03 ` Hannes Reinecke
2015-09-29 10:47 ` [PATCH 09/36] scsi_dh_alua: fixup description of stpg_endio() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 10/36] scsi: remove scsi_show_sense_hdr() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 11/36] scsi_dh_alua: use flag for RTPG extended header Hannes Reinecke
2015-09-29 10:47 ` [PATCH 12/36] scsi_dh_alua: use unaligned access macros Hannes Reinecke
2015-10-02 0:01 ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 13/36] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2015-09-29 10:47 ` [PATCH 14/36] scsi_dh_alua: separate out alua_stpg() Hannes Reinecke
2015-10-02 0:07 ` Bart Van Assche
2015-10-02 6:06 ` Hannes Reinecke
2015-10-02 15:03 ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 15/36] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2015-10-02 17:33 ` Bart Van Assche
2015-10-07 20:48 ` Hannes Reinecke
2015-09-29 10:47 ` [PATCH 16/36] scsi_dh_alua: call alua_rtpg() if stpg fails Hannes Reinecke
2015-10-02 17:14 ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 17/36] scsi_dh_alua: switch to scsi_execute_req_flags() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 18/36] scsi_dh_alua: rework alua_check_tpgs() to return the tpgs mode Hannes Reinecke
2015-09-29 10:47 ` [PATCH 19/36] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2015-09-29 10:47 ` [PATCH 20/36] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2015-09-29 10:47 ` [PATCH 21/36] scsi_dh_alua: simplify sense code handling Hannes Reinecke
2015-09-29 10:47 ` [PATCH 22/36] scsi: Add scsi_vpd_lun_id() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 23/36] scsi_dh_alua: use unique device id Hannes Reinecke
2015-09-29 10:47 ` Hannes Reinecke [this message]
2015-09-29 10:47 ` [PATCH 25/36] scsi_dh_alua: simplify alua_initialize() Hannes Reinecke
2015-09-29 10:47 ` [PATCH 26/36] revert "scsi_dh_alua: ALUA hander attach should succeed while TPG is transitioning" Hannes Reinecke
2015-09-29 10:47 ` [PATCH 27/36] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2015-09-29 13:27 ` kbuild test robot
2015-10-01 23:34 ` Bart Van Assche
2015-10-02 5:59 ` Hannes Reinecke
2015-09-29 10:47 ` [PATCH 28/36] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2015-09-29 10:47 ` [PATCH 29/36] scsi_dh_alua: update all port states Hannes Reinecke
2015-09-29 10:47 ` [PATCH 30/36] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2015-09-29 10:47 ` [PATCH 31/36] scsi: rescan VPD attributes Hannes Reinecke
2015-09-29 13:38 ` kbuild test robot
2015-09-29 13:40 ` kbuild test robot
2015-09-29 13:40 ` [PATCH] scsi: fix ifnullfree.cocci warnings kbuild test robot
2015-09-29 10:47 ` [PATCH 32/36] scsi_dh: add 'rescan' callback Hannes Reinecke
2015-09-29 10:47 ` [PATCH 33/36] scsi: Add 'access_state' attribute Hannes Reinecke
2015-09-29 13:51 ` kbuild test robot
2015-10-01 23:04 ` Bart Van Assche
2015-09-29 10:47 ` [PATCH 34/36] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2015-09-29 10:47 ` [PATCH 35/36] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2015-09-29 10:47 ` [PATCH 36/36] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
2015-09-29 18:29 ` [PATCHv5 00/36] asynchronous ALUA device handler Bart Van Assche
2015-09-30 13:21 ` Hannes Reinecke
2015-09-30 21:32 ` Bart Van Assche
2015-10-13 9:44 ` Hannes Reinecke
2015-10-13 15:07 ` Bart Van Assche
2015-10-13 15:13 ` Hannes Reinecke
2015-10-13 15:40 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1443523658-87622-25-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).