From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andy Shevchenko Subject: Re: [PATCH] scsi: fnic: use kernel's '%pM' format option to print MAC Date: Wed, 30 Sep 2015 20:17:08 +0300 Message-ID: <1443633428.8361.317.camel@linux.intel.com> References: <1398782723-13433-1-git-send-email-andriy.shevchenko@linux.intel.com> <1426787642.14897.375.camel@linux.intel.com> <550B8B0D.6010901@opengridcomputing.com> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <550B8B0D.6010901-7bPotxP6k4+P2YhJcF5u+vpXobYPEAuW@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Tom Tucker , linux-scsi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: Hiral Patel , Steve Wise , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-scsi@vger.kernel.org On Thu, 2015-03-19 at 21:50 -0500, Tom Tucker wrote: > Hi Andy, > > On 3/19/15 12:54 PM, Andy Shevchenko wrote: > > On Tue, 2014-04-29 at 17:45 +0300, Andy Shevchenko wrote: > > > Instead of supplying each byte through stack let's use %pM > > > specifier. > > Anyone to comment or apply this patch? > > > > > Signed-off-by: Andy Shevchenko > > > > > > Cc: Tom Tucker > > > Cc: Steve Wise > > > Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org > > > --- > > > drivers/scsi/fnic/vnic_dev.c | 10 ++-------- > > > 1 file changed, 2 insertions(+), 8 deletions(-) > > > > > > diff --git a/drivers/scsi/fnic/vnic_dev.c > > > b/drivers/scsi/fnic/vnic_dev.c > > > index 9795d6f..ba69d61 100644 > > > --- a/drivers/scsi/fnic/vnic_dev.c > > > +++ b/drivers/scsi/fnic/vnic_dev.c > > > @@ -499,10 +499,7 @@ void vnic_dev_add_addr(struct vnic_dev > > > *vdev, u8 *addr) > > > > > > err = vnic_dev_cmd(vdev, CMD_ADDR_ADD, &a0, &a1, wait); > > > if (err) > > > - printk(KERN_ERR > > > - "Can't add addr > > > [%02x:%02x:%02x:%02x:%02x:%02x], %d\n", > > > - addr[0], addr[1], addr[2], addr[3], > > > addr[4], addr[5], > > > - err); > > > + pr_err("Can't add addr [%pM], %d\n", addr, err); > > This looks completely reasonable to me. Anyone to apply then? > > Tom > > > } > > > > > > void vnic_dev_del_addr(struct vnic_dev *vdev, u8 *addr) > > > @@ -517,10 +514,7 @@ void vnic_dev_del_addr(struct vnic_dev > > > *vdev, u8 *addr) > > > > > > err = vnic_dev_cmd(vdev, CMD_ADDR_DEL, &a0, &a1, wait); > > > if (err) > > > - printk(KERN_ERR > > > - "Can't del addr > > > [%02x:%02x:%02x:%02x:%02x:%02x], %d\n", > > > - addr[0], addr[1], addr[2], addr[3], > > > addr[4], addr[5], > > > - err); > > > + pr_err("Can't del addr [%pM], %d\n", addr, err); > > > } > > > > > > int vnic_dev_notify_set(struct vnic_dev *vdev, u16 intr) > > > -- Andy Shevchenko Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html