Re: [PATCH -resend 1/1] fcoe: use continue instead of goto+label

[Vasu Dev <vasu.dev-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]

On Tue, 2015-10-06 at 14:27 +0200, Jiri Slaby wrote:
> There is a label pointing to the start of a while loop and a goto
> nested only in the loop. The goto jumps to the label in some cases.
> Replace the goto and the label by simple continue.
> 
> Signed-off-by: Jiri Slaby <jslaby-AlSwsSmVLrQ@public.gmane.org>
> Cc: Robert Love <robert.w.love-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> Cc: fcoe-devel-s9riP+hp16TNLxjTenLetw@public.gmane.org
> ---
> Sent on:
> May 5
> 
>  drivers/scsi/fcoe/fcoe.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
> 
> diff --git a/drivers/scsi/fcoe/fcoe.c b/drivers/scsi/fcoe/fcoe.c
> index d3eb80c46bbe..d187ba9b361d 100644
> --- a/drivers/scsi/fcoe/fcoe.c
> +++ b/drivers/scsi/fcoe/fcoe.c
> @@ -1873,7 +1873,6 @@ static int fcoe_percpu_receive_thread(void *arg)
>  
>  	set_user_nice(current, MIN_NICE);
>  
> -retry:
>  	while (!kthread_should_stop()) {
>  
>  		spin_lock_bh(&p->fcoe_rx_list.lock);
> @@ -1883,7 +1882,7 @@ retry:
>  			set_current_state(TASK_INTERRUPTIBLE);
>  			spin_unlock_bh(&p->fcoe_rx_list.lock);
>  			schedule();
> -			goto retry;
> +			continue;
>  		}
>  
>  		spin_unlock_bh(&p->fcoe_rx_list.lock);

Acked-by: Vasu Dev <vasu.dev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>