linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Yaniv Gardi <ygardi@codeaurora.org>
To: James.Bottomley@HansenPartnership.com
Cc: linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org,
	linux-arm-msm@vger.kernel.org, santoshsy@gmail.com,
	linux-scsi-owner@vger.kernel.org, subhashj@codeaurora.org,
	ygardi@codeaurora.org, gbroner@codeaurora.org,
	draviv@codeaurora.org, Vinayak Holikatti <vinholikatti@gmail.com>,
	"James E.J. Bottomley" <JBottomley@odin.com>
Subject: [PATCH v4 14/15] scsi: ufs: commit descriptors before setting the doorbell
Date: Sun, 25 Oct 2015 16:56:23 +0200	[thread overview]
Message-ID: <1445784984-16443-15-git-send-email-ygardi@codeaurora.org> (raw)
In-Reply-To: <1445784984-16443-1-git-send-email-ygardi@codeaurora.org>

Add a write memory barrier to make sure descriptors prepared are actually
written to memory before ringing the doorbell. We have also added the
write memory barrier after ringing the doorbell register so that
controller sees the new request immediately.

Signed-off-by: Gilad Broner <gbroner@codeaurora.org>
Signed-off-by: Subhash Jadavani <subhashj@codeaurora.org>
Signed-off-by: Yaniv Gardi <ygardi@codeaurora.org>

---
 drivers/scsi/ufs/ufshcd.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
index 14bebc5..c87bd4b 100644
--- a/drivers/scsi/ufs/ufshcd.c
+++ b/drivers/scsi/ufs/ufshcd.c
@@ -1628,6 +1628,8 @@ static int ufshcd_exec_dev_cmd(struct ufs_hba *hba,
 
 	hba->dev_cmd.complete = &wait;
 
+	/* Make sure descriptors are ready before ringing the doorbell */
+	wmb();
 	spin_lock_irqsave(hba->host->host_lock, flags);
 	ufshcd_send_command(hba, tag);
 	spin_unlock_irqrestore(hba->host->host_lock, flags);
-- 
1.8.5.2

-- 
QUALCOMM ISRAEL, on behalf of Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation

  parent reply	other threads:[~2015-10-25 14:56 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-10-25 14:56 [PATCH v4 00/15] Big fixes, retries, handle a race condition Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 01/15] scsi: ufs: clear UTRD, UPIU req and rsp before new transfers Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 02/15] scsi: ufs: clear fields " Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 03/15] scsi: ufs: verify command tag validity Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 04/15] scsi: ufs: clear outstanding_request bit in case query timeout Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 05/15] scsi: ufs: increase fDeviceInit query response timeout Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 06/15] scsi: ufs: avoid exception event handler racing with PM callbacks Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 07/15] scsi: ufs: set REQUEST_SENSE command size to 18 bytes Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 08/15] scsi: ufs: add retries to dme_peer get and set attribute Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 09/15] scsi: ufs: add retries for hibern8 enter Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 10/15] scsi: ufs: fix error recovery after the hibern8 exit failure Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 11/15] scsi: ufs: retry failed query flag requests Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 12/15] scsi: ufs: reduce the interrupts for power mode change requests Yaniv Gardi
2015-10-25 14:56 ` [PATCH v4 13/15] scsi: ufs: add missing memory barriers Yaniv Gardi
2015-10-25 14:56 ` Yaniv Gardi [this message]
2015-10-25 14:56 ` [PATCH v4 15/15] scsi: ufs: add wrapper for retrying sending query attribute Yaniv Gardi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1445784984-16443-15-git-send-email-ygardi@codeaurora.org \
    --to=ygardi@codeaurora.org \
    --cc=JBottomley@odin.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=draviv@codeaurora.org \
    --cc=gbroner@codeaurora.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi-owner@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=santoshsy@gmail.com \
    --cc=subhashj@codeaurora.org \
    --cc=vinholikatti@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).