From: Ewan Milne <emilne@redhat.com>
To: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
Cc: "James E.J. Bottomley" <JBottomley@odin.com>,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code
Date: Tue, 27 Oct 2015 12:12:11 -0400 [thread overview]
Message-ID: <1445962331.4119.28.camel@localhost.localdomain> (raw)
In-Reply-To: <562E3E9F.50600@linux.vnet.ibm.com>
On Mon, 2015-10-26 at 15:54 +0100, Peter Oberparleiter wrote:
> Writing a number to /sys/bus/scsi/devices/<sdev>/queue_ramp_up_period
> returns the value of that number instead of the number of bytes written.
> This behavior can confuse programs expecting POSIX write() semantics.
> Fix this by returning the number of bytes written instead.
>
> Signed-off-by: Peter Oberparleiter <oberpar@linux.vnet.ibm.com>
> ---
> drivers/scsi/scsi_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_sysfs.c b/drivers/scsi/scsi_sysfs.c
> index b333389..6b0f292 100644
> --- a/drivers/scsi/scsi_sysfs.c
> +++ b/drivers/scsi/scsi_sysfs.c
> @@ -898,7 +898,7 @@ sdev_store_queue_ramp_up_period(struct device *dev,
> return -EINVAL;
>
> sdev->queue_ramp_up_period = msecs_to_jiffies(period);
> - return period;
> + return count;
> }
>
> static DEVICE_ATTR(queue_ramp_up_period, S_IRUGO | S_IWUSR,
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
prev parent reply other threads:[~2015-10-27 16:12 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-26 14:54 [PATCH] scsi_sysfs: Fix queue_ramp_up_period return code Peter Oberparleiter
2015-10-27 1:56 ` Bart Van Assche
2015-10-27 6:57 ` Hannes Reinecke
2015-10-27 16:12 ` Ewan Milne [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445962331.4119.28.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=JBottomley@odin.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=oberpar@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).