From: Johannes Thumshirn <jthumshirn@suse.de>
To: Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org,
James.Bottomley@HansenPartnership.com
Subject: Re: [PATCH] scsi: restart list search after unlock in scsi_remove_target
Date: Tue, 27 Oct 2015 17:33:21 +0100 [thread overview]
Message-ID: <1445963601.16404.45.camel@suse.de> (raw)
In-Reply-To: <20151019143546.GA7486@lst.de>
On Mon, 2015-10-19 at 16:35 +0200, Christoph Hellwig wrote:
> When dropping a lock while iterating a list we must restart the
> search
> as other threads could have manipulated the list under us. Without
> this
> we can get stuck in an endless loop.
>
> Reported-by: Johannes Thumshirn <jthumshirn@suse.de>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
I have an official acknowledge from the original author that a 48h long
term test on their side didn't reproduce the lockup as well.
James can we please get the patch included in 4.4 and stable?
Thanks
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
prev parent reply other threads:[~2015-10-27 16:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-19 14:35 [PATCH] scsi: restart list search after unlock in scsi_remove_target Christoph Hellwig
2015-10-19 15:36 ` Bart Van Assche
2015-10-19 15:56 ` Christoph Hellwig
2015-10-19 16:01 ` James Bottomley
2015-10-19 17:21 ` Dan Williams
2015-10-26 8:35 ` Johannes Thumshirn
2015-10-27 20:14 ` Bart Van Assche
2015-10-30 8:26 ` Johannes Thumshirn
2015-10-27 16:33 ` Johannes Thumshirn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1445963601.16404.45.camel@suse.de \
--to=jthumshirn@suse.de \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).