From: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
To: linux-scsi@vger.kernel.org
Cc: brking@linux.vnet.ibm.com, wenxiong@linux.vnet.ibm.com,
Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
Subject: [PATCH 2/5] ipr: Clear NO_ULEN_CHK bit when resource is a vset.
Date: Fri, 30 Oct 2015 14:49:06 -0200 [thread overview]
Message-ID: <1446223749-17416-2-git-send-email-krisman@linux.vnet.ibm.com> (raw)
In-Reply-To: <1446223749-17416-1-git-send-email-krisman@linux.vnet.ibm.com>
According to the IPR specification, Inhibit Underlength Checking bit
must be disabled when sending commands to vsets. Enabling this bit for
vset might cause SCSI commands to fail with an Illegal Request.
Signed-off-by: Gabriel Krisman Bertazi <krisman@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/ipr.c b/drivers/scsi/ipr.c
index 4034cd3..da957b3 100644
--- a/drivers/scsi/ipr.c
+++ b/drivers/scsi/ipr.c
@@ -6364,7 +6364,7 @@ static int ipr_queuecommand(struct Scsi_Host *shost,
ipr_cmd->done = ipr_scsi_eh_done;
if (ipr_is_gscsi(res) || ipr_is_vset_device(res)) {
- if (scsi_cmd->underflow == 0)
+ if (scsi_cmd->underflow == 0 && !ipr_is_vset_device(res))
ioarcb->cmd_pkt.flags_hi |= IPR_FLAGS_HI_NO_ULEN_CHK;
ioarcb->cmd_pkt.flags_hi |= IPR_FLAGS_HI_NO_LINK_DESC;
--
2.1.0
next prev parent reply other threads:[~2015-10-30 16:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-30 16:49 [PATCH 1/5] ipr: Add delay to ensure coherent dumps Gabriel Krisman Bertazi
2015-10-30 16:49 ` Gabriel Krisman Bertazi [this message]
2015-10-30 17:52 ` [PATCH 2/5] ipr: Clear NO_ULEN_CHK bit when resource is a vset Manoj Kumar
2015-10-30 16:49 ` [PATCH 3/5] ipr: Inquiry IOA page 0xC4 during initialization Gabriel Krisman Bertazi
2015-10-30 22:08 ` Brian King
2015-10-30 16:49 ` [PATCH 4/5] ipr: Issue Configure Cache Parameters command Gabriel Krisman Bertazi
2015-10-30 16:49 ` [PATCH 5/5] ipr: Driver version 2.6.3 Gabriel Krisman Bertazi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446223749-17416-2-git-send-email-krisman@linux.vnet.ibm.com \
--to=krisman@linux.vnet.ibm.com \
--cc=brking@linux.vnet.ibm.com \
--cc=linux-scsi@vger.kernel.org \
--cc=wenxiong@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox