From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: Bart Van Assche <bart.vanassche@sandisk.com>
Cc: "linux@rasmusvillemoes.dk" <linux@rasmusvillemoes.dk>,
linux-scsi <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH v2] string_helpers: fix precision loss for some inputs
Date: Tue, 03 Nov 2015 14:37:35 -0800 [thread overview]
Message-ID: <1446590255.6440.48.camel@HansenPartnership.com> (raw)
In-Reply-To: <563928FD.8010901@sandisk.com>
On Tue, 2015-11-03 at 13:37 -0800, Bart Van Assche wrote:
> On 11/03/2015 01:21 PM, James Bottomley wrote:
> > + while (blk_size >= UINT_MAX)
> > i++;
>
> (reduced CC-list)
Let's keep at least the lists in cc.
> Hello James,
>
> Is the above loop an infinite loop if blk_size >= UINT_MAX ?
Yes, a little too much truncation over the original. I'll post a v3.
James
next prev parent reply other threads:[~2015-11-03 22:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-03 20:33 [PATCH] string_helpers: fix precision loss for some inputs James Bottomley
2015-11-03 21:21 ` [PATCH v2] " James Bottomley
2015-11-03 22:13 ` Rasmus Villemoes
2015-11-03 22:54 ` James Bottomley
2015-11-03 23:26 ` Rasmus Villemoes
2015-11-03 23:42 ` James Bottomley
2015-11-04 9:02 ` Rasmus Villemoes
[not found] ` <563928FD.8010901@sandisk.com>
2015-11-03 22:37 ` James Bottomley [this message]
2015-11-03 23:12 ` [PATCH v3] " James Bottomley
2015-11-07 0:50 ` [PATCH v4] " James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1446590255.6440.48.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=bart.vanassche@sandisk.com \
--cc=linux-scsi@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox