linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
	Jamed Bottomley <jbottomley@odin.com>,
	linux-scsi@vger.kernel.org,
	Johannes Thumshirn <jthumshirn@suse.com>,
	Ewan Milne <emilne@redhat.com>, Hannes Reinecke <hare@suse.de>
Subject: [PATCH 15/18] scsi: Add scsi_vpd_lun_id()
Date: Mon,  9 Nov 2015 16:08:20 +0100	[thread overview]
Message-ID: <1447081703-110552-16-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1447081703-110552-1-git-send-email-hare@suse.de>

Add a function scsi_vpd_lun_id() to return a unique device
identifcation based on the designation descriptors of
VPD page 0x83.

As devices might implement several descriptors the order
of preference is:
- NAA IEE Registered Extended
- EUI-64 based 16-byte
- EUI-64 based 12-byte
- NAA IEEE Registered
- NAA IEEE Extended
A SCSI name string descriptor is preferred to all of them
if the identification is longer than 16 bytes.

The returned unique device identification will be formatted
as a SCSI Name string to avoid clashes between different
designator types.

Reviewed-by: Ewan Milne <emilne@redhat.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/scsi/scsi_lib.c    | 140 +++++++++++++++++++++++++++++++++++++++++++++
 include/scsi/scsi_device.h |   1 +
 2 files changed, 141 insertions(+)

diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index cbfc599..3cb295c 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -3154,3 +3154,143 @@ void sdev_enable_disk_events(struct scsi_device *sdev)
 	atomic_dec(&sdev->disk_events_disable_depth);
 }
 EXPORT_SYMBOL(sdev_enable_disk_events);
+
+/*
+ * scsi_vpd_lun_id - return a unique device identification
+ * @sdev: SCSI device
+ * @id:   buffer for the identification
+ * @id_len:  length of the buffer
+ *
+ * Copies a unique device identification into @id based
+ * on the information in the VPD page 0x83 of the device.
+ * The string will be formatted as a SCSI name string.
+ *
+ * Returns the length of the identification or error on failure.
+ * If the identifier is longer than the supplied buffer the actual
+ * identifier length is returned and the buffer is not zero-padded.
+ */
+int scsi_vpd_lun_id(struct scsi_device *sdev, char *id, size_t id_len)
+{
+	u8 cur_id_type = 0xff;
+	u8 cur_id_size = 0;
+	unsigned char *d, *cur_id_str;
+	unsigned char __rcu *vpd_pg83;
+	int id_size = -EINVAL;
+
+	rcu_read_lock();
+	vpd_pg83 = rcu_dereference(sdev->vpd_pg83);
+	if (!vpd_pg83) {
+		rcu_read_unlock();
+		return -ENXIO;
+	}
+
+	/*
+	 * Look for the correct descriptor.
+	 * Order of preference for lun descriptor:
+	 * - SCSI name string
+	 * - NAA IEEE Registered Extended
+	 * - EUI-64 based 16-byte
+	 * - EUI-64 based 12-byte
+	 * - NAA IEEE Registered
+	 * - NAA IEEE Extended
+	 * as longer descriptors reduce the likelyhood
+	 * of identification clashes.
+	 */
+
+	/* The id string must be at least 20 bytes + terminating NULL byte */
+	if (id_len < 21) {
+		rcu_read_unlock();
+		return -EINVAL;
+	}
+
+	memset(id, 0, id_len);
+	d = vpd_pg83 + 4;
+	while (d < vpd_pg83 + sdev->vpd_pg83_len) {
+		/* Skip designators not referring to the LUN */
+		if ((d[1] & 0x30) != 0x00)
+			goto next_desig;
+
+		switch (d[1] & 0xf) {
+		case 0x2:
+			/* EUI-64 */
+			if (cur_id_size > d[3])
+				break;
+			/* Prefer NAA IEEE Registered Extended */
+			if (cur_id_type == 0x3 &&
+			    cur_id_size == d[3])
+				break;
+			cur_id_size = d[3];
+			cur_id_str = d + 4;
+			cur_id_type = d[1] & 0xf;
+			switch (cur_id_size) {
+			case 8:
+				id_size = snprintf(id, id_len,
+						   "eui.%8phN",
+						   cur_id_str);
+				break;
+			case 12:
+				id_size = snprintf(id, id_len,
+						   "eui.%12phN",
+						   cur_id_str);
+				break;
+			case 16:
+				id_size = snprintf(id, id_len,
+						   "eui.%16phN",
+						   cur_id_str);
+				break;
+			default:
+				cur_id_size = 0;
+				break;
+			}
+			break;
+		case 0x3:
+			/* NAA */
+			if (cur_id_size > d[3])
+				break;
+			cur_id_size = d[3];
+			cur_id_str = d + 4;
+			cur_id_type = d[1] & 0xf;
+			switch (cur_id_size) {
+			case 8:
+				id_size = snprintf(id, id_len,
+						   "naa.%8phN",
+						   cur_id_str);
+				break;
+			case 16:
+				id_size = snprintf(id, id_len,
+						   "naa.%16phN",
+						   cur_id_str);
+				break;
+			default:
+				cur_id_size = 0;
+				break;
+			}
+			break;
+		case 0x8:
+			/* SCSI name string */
+			if (cur_id_size + 4 > d[3])
+				break;
+			/* Prefer others for truncated descriptor */
+			if (cur_id_size && d[3] > id_len)
+				break;
+			cur_id_size = id_size = d[3];
+			cur_id_str = d + 4;
+			cur_id_type = d[1] & 0xf;
+			if (cur_id_size >= id_len)
+				cur_id_size = id_len - 1;
+			memcpy(id, cur_id_str, cur_id_size);
+			/* Decrease priority for truncated descriptor */
+			if (cur_id_size != id_size)
+				cur_id_size = 6;
+			break;
+		default:
+			break;
+		}
+next_desig:
+		d += d[3] + 4;
+	}
+	rcu_read_unlock();
+
+	return id_size;
+}
+EXPORT_SYMBOL(scsi_vpd_lun_id);
diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
index bde4077..4c49cfa 100644
--- a/include/scsi/scsi_device.h
+++ b/include/scsi/scsi_device.h
@@ -415,6 +415,7 @@ static inline int scsi_execute_req(struct scsi_device *sdev,
 }
 extern void sdev_disable_disk_events(struct scsi_device *sdev);
 extern void sdev_enable_disk_events(struct scsi_device *sdev);
+extern int scsi_vpd_lun_id(struct scsi_device *, char *, size_t);
 
 #ifdef CONFIG_PM
 extern int scsi_autopm_get_device(struct scsi_device *);
-- 
1.8.5.6


  parent reply	other threads:[~2015-11-09 15:08 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-11-09 15:08 [PATCH 00/18] ALUA device handler update, part 1 Hannes Reinecke
2015-11-09 15:08 ` [PATCH 01/18] scsi_dh: move 'dh_state' sysfs attribute to generic code Hannes Reinecke
2015-11-24 12:14   ` Johannes Thumshirn
2015-11-30 16:59   ` Martin K. Petersen
2015-11-09 15:08 ` [PATCH 02/18] scsi: ignore errors from scsi_dh_add_device() Hannes Reinecke
2015-11-24 12:14   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 03/18] scsi_dh_alua: Disable ALUA handling for non-disk devices Hannes Reinecke
2015-11-24 12:14   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 04/18] scsi_dh_alua: Use vpd_pg83 information Hannes Reinecke
2015-11-24 12:15   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 05/18] scsi_dh_alua: improved logging Hannes Reinecke
2015-11-24 12:15   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 06/18] scsi_dh_alua: sanitze sense code handling Hannes Reinecke
2015-11-24 12:16   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 07/18] scsi_dh_alua: use standard logging functions Hannes Reinecke
2015-11-24 12:16   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 08/18] scsi_dh_alua: return standard SCSI return codes in submit_rtpg Hannes Reinecke
2015-11-24 12:16   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 09/18] scsi_dh_alua: fixup description of stpg_endio() Hannes Reinecke
2015-11-24 12:16   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 10/18] scsi: remove scsi_show_sense_hdr() Hannes Reinecke
2015-11-24 12:16   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 11/18] scsi_dh_alua: use flag for RTPG extended header Hannes Reinecke
2015-11-24 12:16   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 12/18] scsi_dh_alua: use unaligned access macros Hannes Reinecke
2015-11-24 12:17   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 13/18] scsi_dh_alua: rework alua_check_tpgs() to return the tpgs mode Hannes Reinecke
2015-11-24 12:17   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 14/18] scsi_dh_alua: simplify sense code handling Hannes Reinecke
2015-11-24 12:17   ` Johannes Thumshirn
2015-11-09 15:08 ` Hannes Reinecke [this message]
2015-11-24 12:17   ` [PATCH 15/18] scsi: Add scsi_vpd_lun_id() Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 16/18] scsi: export 'device_id' to sysfs Hannes Reinecke
2015-11-24 12:17   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 17/18] scsi: Add scsi_vpd_tpg_id() Hannes Reinecke
2015-11-24 12:17   ` Johannes Thumshirn
2015-11-09 15:08 ` [PATCH 18/18] scsi_dh_alua: use scsi_vpd_tpg_id() Hannes Reinecke
2015-11-24 12:18   ` Johannes Thumshirn
2015-11-19  8:35 ` [PATCH 00/18] ALUA device handler update, part 1 Christoph Hellwig
2015-11-19  9:42   ` Hannes Reinecke
2015-11-20 10:47 ` Christoph Hellwig
2015-11-20 10:52   ` Hannes Reinecke
2015-11-20 10:54     ` Christoph Hellwig
2015-11-20 11:02       ` Hannes Reinecke
2015-11-20 22:58     ` Bart Van Assche
2015-11-23 16:10       ` Hannes Reinecke
2015-11-23 16:18         ` Bart Van Assche
2015-11-24 15:29           ` Hannes Reinecke
  -- strict thread matches above, loose matches on Subject: below --
2015-12-01  9:16 [PATCHv2 " Hannes Reinecke
2015-12-01  9:16 ` [PATCH 15/18] scsi: Add scsi_vpd_lun_id() Hannes Reinecke
2015-12-01 10:35   ` Johannes Thumshirn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1447081703-110552-16-git-send-email-hare@suse.de \
    --to=hare@suse.de \
    --cc=emilne@redhat.com \
    --cc=hch@lst.de \
    --cc=jbottomley@odin.com \
    --cc=jthumshirn@suse.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).