* [PATCH] lpfc: replaced kmalloc + memset with kzalloc
@ 2015-10-28 6:53 Saurabh Sengar
2015-11-19 7:34 ` [PATCH v2] " Saurabh Sengar
0 siblings, 1 reply; 4+ messages in thread
From: Saurabh Sengar @ 2015-10-28 6:53 UTC (permalink / raw)
To: james.smart, dick.kennedy, JBottomley, linux-scsi, linux-kernel
Cc: Saurabh Sengar
replacing kmalloc and memset by a single call of kzalloc
Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
drivers/scsi/lpfc/lpfc_els.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 36bf58b..9729ab1 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -4990,13 +4990,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
if (RDP_NPORT_ID_SIZE !=
be32_to_cpu(rdp_req->nport_id_desc.length))
goto rjt_logerr;
- rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
+ rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
if (!rdp_context) {
rjt_err = LSRJT_UNABLE_TPC;
goto error;
}
- memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
cmd = &cmdiocb->iocb;
rdp_context->ndlp = lpfc_nlp_get(ndlp);
rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc
2015-10-28 6:53 [PATCH] lpfc: replaced kmalloc + memset with kzalloc Saurabh Sengar
@ 2015-11-19 7:34 ` Saurabh Sengar
2015-11-22 23:14 ` Sebastian Herbszt
2015-12-16 23:20 ` James Smart
0 siblings, 2 replies; 4+ messages in thread
From: Saurabh Sengar @ 2015-11-19 7:34 UTC (permalink / raw)
To: james.smart, dick.kennedy, JBottomley, linux-scsi, linux-kernel
Cc: Saurabh Sengar
replacing kmalloc and memset by a single call of kzalloc
Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
---
v2 : I didn't got any response for my initial patch,
I am sending it again on top of latest kernel(today's)
drivers/scsi/lpfc/lpfc_els.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index b6fa257..92dd204 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -4956,13 +4956,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
if (RDP_NPORT_ID_SIZE !=
be32_to_cpu(rdp_req->nport_id_desc.length))
goto rjt_logerr;
- rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
+ rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
if (!rdp_context) {
rjt_err = LSRJT_UNABLE_TPC;
goto error;
}
- memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
cmd = &cmdiocb->iocb;
rdp_context->ndlp = lpfc_nlp_get(ndlp);
rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc
2015-11-19 7:34 ` [PATCH v2] " Saurabh Sengar
@ 2015-11-22 23:14 ` Sebastian Herbszt
2015-12-16 23:20 ` James Smart
1 sibling, 0 replies; 4+ messages in thread
From: Sebastian Herbszt @ 2015-11-22 23:14 UTC (permalink / raw)
To: Saurabh Sengar
Cc: james.smart, dick.kennedy, JBottomley, linux-scsi, linux-kernel,
Sebastian Herbszt
Saurabh Sengar wrote:
> replacing kmalloc and memset by a single call of kzalloc
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
> ---
> v2 : I didn't got any response for my initial patch,
> I am sending it again on top of latest kernel(today's)
>
> drivers/scsi/lpfc/lpfc_els.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index b6fa257..92dd204 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4956,13 +4956,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
> if (RDP_NPORT_ID_SIZE !=
> be32_to_cpu(rdp_req->nport_id_desc.length))
> goto rjt_logerr;
> - rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> + rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> if (!rdp_context) {
> rjt_err = LSRJT_UNABLE_TPC;
> goto error;
> }
>
> - memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
> cmd = &cmdiocb->iocb;
> rdp_context->ndlp = lpfc_nlp_get(ndlp);
> rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
Same patch was already sent by Punit Vara on 2015-10-24.
Sebastian
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] lpfc: replaced kmalloc + memset with kzalloc
2015-11-19 7:34 ` [PATCH v2] " Saurabh Sengar
2015-11-22 23:14 ` Sebastian Herbszt
@ 2015-12-16 23:20 ` James Smart
1 sibling, 0 replies; 4+ messages in thread
From: James Smart @ 2015-12-16 23:20 UTC (permalink / raw)
To: Saurabh Sengar, dick.kennedy, JBottomley, linux-scsi,
linux-kernel
fyi - this patch was just pushed in our 11.0.0.10 patch set - patch 16/17
Note: Patch 16 contains the exact same patch submitted by Punit Vara. I
posted Punit's change only as it arrived earlier.
-- james s
On 11/18/2015 11:34 PM, Saurabh Sengar wrote:
> replacing kmalloc and memset by a single call of kzalloc
>
> Signed-off-by: Saurabh Sengar <saurabh.truth@gmail.com>
> ---
> v2 : I didn't got any response for my initial patch,
> I am sending it again on top of latest kernel(today's)
>
> drivers/scsi/lpfc/lpfc_els.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index b6fa257..92dd204 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -4956,13 +4956,12 @@ lpfc_els_rcv_rdp(struct lpfc_vport *vport, struct lpfc_iocbq *cmdiocb,
> if (RDP_NPORT_ID_SIZE !=
> be32_to_cpu(rdp_req->nport_id_desc.length))
> goto rjt_logerr;
> - rdp_context = kmalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> + rdp_context = kzalloc(sizeof(struct lpfc_rdp_context), GFP_KERNEL);
> if (!rdp_context) {
> rjt_err = LSRJT_UNABLE_TPC;
> goto error;
> }
>
> - memset(rdp_context, 0, sizeof(struct lpfc_rdp_context));
> cmd = &cmdiocb->iocb;
> rdp_context->ndlp = lpfc_nlp_get(ndlp);
> rdp_context->ox_id = cmd->unsli3.rcvsli3.ox_id;
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-16 23:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-10-28 6:53 [PATCH] lpfc: replaced kmalloc + memset with kzalloc Saurabh Sengar
2015-11-19 7:34 ` [PATCH v2] " Saurabh Sengar
2015-11-22 23:14 ` Sebastian Herbszt
2015-12-16 23:20 ` James Smart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).