From: Johannes Thumshirn <jthumshirn@suse.com>
To: Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>, Ewan Milne <emilne@redhat.com>,
James Bottomley <jbottomley@odin.com>,
Bart van Assche <bart.vanassche@sandisk.com>,
linux-scsi@vger.kernel.org
Subject: Re: [PATCH 09/18] scsi_dh_alua: fixup description of stpg_endio()
Date: Tue, 01 Dec 2015 11:09:00 +0100 [thread overview]
Message-ID: <1448964540.3103.8.camel@suse.com> (raw)
In-Reply-To: <1448961418-29013-10-git-send-email-hare@suse.de>
On Tue, 2015-12-01 at 10:16 +0100, Hannes Reinecke wrote:
> Fixup copy-and-paste error in the description of stpg_endio().
>
> Signed-off-by: Hannes Reinecke <hare@suse.de>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
> Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
> ---
> drivers/scsi/device_handler/scsi_dh_alua.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c
> b/drivers/scsi/device_handler/scsi_dh_alua.c
> index 50fe87c..ea626732 100644
> --- a/drivers/scsi/device_handler/scsi_dh_alua.c
> +++ b/drivers/scsi/device_handler/scsi_dh_alua.c
> @@ -171,13 +171,11 @@ done:
> }
>
> /*
> - * alua_stpg - Evaluate SET TARGET GROUP STATES
> + * stpg_endio - Evaluate SET TARGET GROUP STATES
> * @sdev: the device to be evaluated
> * @state: the new target group state
> *
> - * Send a SET TARGET GROUP STATES command to the device.
> - * We only have to test here if we should resubmit the command;
> - * any other error is assumed as a failure.
> + * Evaluate a SET TARGET GROUP STATES command response.
> */
> static void stpg_endio(struct request *req, int error)
> {
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2015-12-01 10:09 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-01 9:16 [PATCHv2 00/18] ALUA device handler update, part 1 Hannes Reinecke
2015-12-01 9:16 ` [PATCH 01/18] scsi_dh: move 'dh_state' sysfs attribute to generic code Hannes Reinecke
2015-12-01 9:16 ` [PATCH 02/18] scsi: ignore errors from scsi_dh_add_device() Hannes Reinecke
2015-12-01 9:16 ` [PATCH 03/18] scsi_dh_alua: Disable ALUA handling for non-disk devices Hannes Reinecke
2015-12-01 9:25 ` Johannes Thumshirn
2015-12-01 9:16 ` [PATCH 04/18] scsi_dh_alua: Use vpd_pg83 information Hannes Reinecke
2015-12-01 9:53 ` Johannes Thumshirn
2015-12-01 9:16 ` [PATCH 05/18] scsi_dh_alua: improved logging Hannes Reinecke
2015-12-01 9:28 ` Johannes Thumshirn
2015-12-01 9:16 ` [PATCH 06/18] scsi_dh_alua: sanitze sense code handling Hannes Reinecke
2015-12-01 9:16 ` [PATCH 07/18] scsi_dh_alua: use standard logging functions Hannes Reinecke
2015-12-01 9:16 ` [PATCH 08/18] scsi_dh_alua: return standard SCSI return codes in submit_rtpg Hannes Reinecke
2015-12-01 10:07 ` Johannes Thumshirn
2015-12-01 9:16 ` [PATCH 09/18] scsi_dh_alua: fixup description of stpg_endio() Hannes Reinecke
2015-12-01 10:09 ` Johannes Thumshirn [this message]
2015-12-01 9:16 ` [PATCH 10/18] scsi: remove scsi_show_sense_hdr() Hannes Reinecke
2015-12-01 10:09 ` Johannes Thumshirn
2015-12-01 9:16 ` [PATCH 11/18] scsi_dh_alua: use flag for RTPG extended header Hannes Reinecke
2015-12-01 10:13 ` Johannes Thumshirn
2015-12-01 9:16 ` [PATCH 12/18] scsi_dh_alua: use unaligned access macros Hannes Reinecke
2015-12-01 10:28 ` Johannes Thumshirn
2015-12-01 9:16 ` [PATCH 13/18] scsi_dh_alua: rework alua_check_tpgs() to return the tpgs mode Hannes Reinecke
2015-12-01 9:16 ` [PATCH 14/18] scsi_dh_alua: simplify sense code handling Hannes Reinecke
2015-12-01 10:31 ` Johannes Thumshirn
2015-12-01 9:16 ` [PATCH 15/18] scsi: Add scsi_vpd_lun_id() Hannes Reinecke
2015-12-01 10:35 ` Johannes Thumshirn
2015-12-01 9:16 ` [PATCH 16/18] scsi: export 'wwid' to sysfs Hannes Reinecke
2015-12-01 9:16 ` [PATCH 17/18] scsi: Add scsi_vpd_tpg_id() Hannes Reinecke
2015-12-01 9:16 ` [PATCH 18/18] scsi_dh_alua: use scsi_vpd_tpg_id() Hannes Reinecke
2015-12-02 22:00 ` [PATCHv2 00/18] ALUA device handler update, part 1 Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2015-11-09 15:08 [PATCH " Hannes Reinecke
2015-11-09 15:08 ` [PATCH 09/18] scsi_dh_alua: fixup description of stpg_endio() Hannes Reinecke
2015-11-24 12:16 ` Johannes Thumshirn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1448964540.3103.8.camel@suse.com \
--to=jthumshirn@suse.com \
--cc=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jbottomley@odin.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).