linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
	Christoph Hellwig <hch@lst.de>,
	Bart von Assche <bart.vanassche@sandisk.com>,
	Ewan Milne <emilne@redhat.com>,
	linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCHv3 15/24] scsi_devinfo: move scsi_get_device_flags into scsi_devinfo.h
Date: Wed, 13 Jan 2016 09:09:50 +0100	[thread overview]
Message-ID: <1452672599-9820-16-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1452672599-9820-1-git-send-email-hare@suse.de>

scsi_get_device_flags is just a wrapper for scsi_get_device_flags_keyed.
The latter is exported, the former isn't. And both functions _and_
the 'key' values are only defined in the (internal) scsi_priv.h
header file.
This patch moves these definitions into scsi_devinfo.h to make them
available for other modules.

Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/scsi/scsi_devinfo.c       | 21 ---------------------
 drivers/scsi/scsi_priv.h          | 12 ------------
 drivers/scsi/scsi_transport_spi.c |  1 +
 include/scsi/scsi_devinfo.h       | 32 ++++++++++++++++++++++++++++++++
 4 files changed, 33 insertions(+), 33 deletions(-)

diff --git a/drivers/scsi/scsi_devinfo.c b/drivers/scsi/scsi_devinfo.c
index 47b9d13..601ff49 100644
--- a/drivers/scsi/scsi_devinfo.c
+++ b/drivers/scsi/scsi_devinfo.c
@@ -546,27 +546,6 @@ static int scsi_dev_info_list_add_str(char *dev_list)
 }
 
 /**
- * get_device_flags - get device specific flags from the dynamic device list.
- * @sdev:       &scsi_device to get flags for
- * @vendor:	vendor name
- * @model:	model name
- *
- * Description:
- *     Search the global scsi_dev_info_list (specified by list zero)
- *     for an entry matching @vendor and @model, if found, return the
- *     matching flags value, else return the host or global default
- *     settings.  Called during scan time.
- **/
-int scsi_get_device_flags(struct scsi_device *sdev,
-			  const unsigned char *vendor,
-			  const unsigned char *model)
-{
-	return scsi_get_device_flags_keyed(sdev, vendor, model,
-					   SCSI_DEVINFO_GLOBAL);
-}
-
-
-/**
  * scsi_get_device_flags_keyed - get device specific flags from the dynamic device list
  * @sdev:       &scsi_device to get flags for
  * @vendor:	vendor name
diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h
index 27b4d0a..b91ffee 100644
--- a/drivers/scsi/scsi_priv.h
+++ b/drivers/scsi/scsi_priv.h
@@ -43,18 +43,6 @@ static inline void scsi_log_completion(struct scsi_cmnd *cmd, int disposition)
 
 /* scsi_devinfo.c */
 
-/* list of keys for the lists */
-enum {
-	SCSI_DEVINFO_GLOBAL = 0,
-	SCSI_DEVINFO_SPI,
-};
-
-extern int scsi_get_device_flags(struct scsi_device *sdev,
-				 const unsigned char *vendor,
-				 const unsigned char *model);
-extern int scsi_get_device_flags_keyed(struct scsi_device *sdev,
-				       const unsigned char *vendor,
-				       const unsigned char *model, int key);
 extern int scsi_dev_info_list_add_keyed(int compatible, char *vendor,
 					char *model, char *strflags,
 					int flags, int key);
diff --git a/drivers/scsi/scsi_transport_spi.c b/drivers/scsi/scsi_transport_spi.c
index 319868f..cae212b 100644
--- a/drivers/scsi/scsi_transport_spi.c
+++ b/drivers/scsi/scsi_transport_spi.c
@@ -35,6 +35,7 @@
 #include <scsi/scsi_tcq.h>
 #include <scsi/scsi_transport.h>
 #include <scsi/scsi_transport_spi.h>
+#include <scsi/scsi_devinfo.h>
 
 #define SPI_NUM_ATTRS 14	/* increase this if you add attributes */
 #define SPI_OTHER_ATTRS 1	/* Increase this if you add "always
diff --git a/include/scsi/scsi_devinfo.h b/include/scsi/scsi_devinfo.h
index 96e3f56..aca3c80 100644
--- a/include/scsi/scsi_devinfo.h
+++ b/include/scsi/scsi_devinfo.h
@@ -38,4 +38,36 @@
 #define BLIST_NO_RSOC		0x20000000 /* don't try to issue RSOC */
 #define BLIST_MAX_1024		0x40000000 /* maximum 1024 sector cdb length */
 
+/* list of keys for the lists */
+enum {
+	SCSI_DEVINFO_GLOBAL = 0,
+	SCSI_DEVINFO_SPI,
+};
+
+extern int scsi_get_device_flags_keyed(struct scsi_device *sdev,
+				       const unsigned char *vendor,
+				       const unsigned char *model, int key);
+
+/**
+ * scsi_get_device_flags - get device specific flags from the dynamic
+ *                         device list.
+ * @sdev:       &scsi_device to get flags for
+ * @vendor:	vendor name
+ * @model:	model name
+ *
+ * Description:
+ *     Search the global scsi_dev_info_list (specified by list zero)
+ *     for an entry matching @vendor and @model, if found, return the
+ *     matching flags value, else return the host or global default
+ *     settings.  Called during scan time.
+ **/
+static inline int scsi_get_device_flags(struct scsi_device *sdev,
+					const unsigned char *vendor,
+					const unsigned char *model)
+{
+	return scsi_get_device_flags_keyed(sdev, vendor, model,
+					   SCSI_DEVINFO_GLOBAL);
+}
+
+
 #endif
-- 
1.8.5.6


  parent reply	other threads:[~2016-01-13  8:10 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-13  8:09 [PATCHv3 00/24] ALUA device handler update, part II Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 01/24] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 02/24] scsi_dh_alua: separate out alua_stpg() Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 03/24] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 04/24] scsi_dh_alua: call alua_rtpg() if stpg fails Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 05/24] scsi_dh_alua: switch to scsi_execute_req_flags() Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 06/24] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 07/24] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 08/24] scsi_dh_alua: use unique device id Hannes Reinecke
2016-01-18 17:44   ` Christoph Hellwig
2016-01-13  8:09 ` [PATCHv3 09/24] scsi_dh_alua: simplify alua_initialize() Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 10/24] revert commit a8e5a2d593cb ("[SCSI] scsi_dh_alua: ALUA handler attach should succeed while TPG is transitioning") Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 11/24] scsi_dh_alua: move optimize_stpg evaluation Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 12/24] scsi_dh_alua: remove 'rel_port' from alua_dh_data structure Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 13/24] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 14/24] scsi_dh_alua: Allow workqueue to run synchronously Hannes Reinecke
2016-01-18 17:45   ` Christoph Hellwig
2016-01-13  8:09 ` Hannes Reinecke [this message]
2016-01-18 17:49   ` [PATCHv3 15/24] scsi_devinfo: move scsi_get_device_flags into scsi_devinfo.h Christoph Hellwig
2016-01-13  8:09 ` [PATCHv3 16/24] scsi_dh_alua: Add new blacklist flag 'BLIST_SYNC_ALUA' Hannes Reinecke
2016-01-18 17:50   ` Christoph Hellwig
2016-01-13  8:09 ` [PATCHv3 17/24] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 18/24] scsi_dh_alua: update all port states Hannes Reinecke
2016-01-18 17:51   ` Christoph Hellwig
2016-01-13  8:09 ` [PATCHv3 19/24] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 20/24] scsi_dh: add 'rescan' callback Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 21/24] scsi: Add 'access_state' attribute Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 22/24] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2016-01-13  8:09 ` [PATCHv3 23/24] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2016-01-18 17:52   ` Christoph Hellwig
2016-01-13  8:09 ` [PATCHv3 24/24] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
2016-01-18 17:52   ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1452672599-9820-16-git-send-email-hare@suse.de \
    --to=hare@suse.de \
    --cc=bart.vanassche@sandisk.com \
    --cc=emilne@redhat.com \
    --cc=hch@lst.de \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).