linux-scsi.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: James Bottomley <james.bottomley@hansenpartnership.com>,
	Christoph Hellwig <hch@infradead.org>,
	Ewan Milne <emilne@redhat.com>,
	Bart van Assche <bart.vanassche@sandisk.com>,
	linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.de>
Subject: [PATCHv4 19/23] scsi_dh: add 'rescan' callback
Date: Tue, 19 Jan 2016 09:22:03 +0100	[thread overview]
Message-ID: <1453191727-3626-20-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1453191727-3626-1-git-send-email-hare@suse.de>

If a device needs to be rescanned the device_handler might need
to be rechecked, too.
So add a 'rescan' callback to the device handler and call it
upon scsi_rescan_device().

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
 drivers/scsi/device_handler/scsi_dh_alua.c | 8 ++++++++
 drivers/scsi/scsi_lib.c                    | 1 +
 drivers/scsi/scsi_scan.c                   | 8 +++++++-
 include/scsi/scsi_dh.h                     | 1 +
 4 files changed, 17 insertions(+), 1 deletion(-)

diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 7f28115..57856d6 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -1025,6 +1025,13 @@ static int alua_prep_fn(struct scsi_device *sdev, struct request *req)
 
 }
 
+static void alua_rescan(struct scsi_device *sdev)
+{
+	struct alua_dh_data *h = sdev->handler_data;
+
+	alua_initialize(sdev, h);
+}
+
 /*
  * alua_bus_attach - Attach device handler
  * @sdev: device to be attached to
@@ -1085,6 +1092,7 @@ static struct scsi_device_handler alua_dh = {
 	.prep_fn = alua_prep_fn,
 	.check_sense = alua_check_sense,
 	.activate = alua_activate,
+	.rescan = alua_rescan,
 	.set_params = alua_set_params,
 };
 
diff --git a/drivers/scsi/scsi_lib.c b/drivers/scsi/scsi_lib.c
index fa6b2c4..d46193a 100644
--- a/drivers/scsi/scsi_lib.c
+++ b/drivers/scsi/scsi_lib.c
@@ -2699,6 +2699,7 @@ static void scsi_evt_emit(struct scsi_device *sdev, struct scsi_event *evt)
 		envp[idx++] = "SDEV_MEDIA_CHANGE=1";
 		break;
 	case SDEV_EVT_INQUIRY_CHANGE_REPORTED:
+		scsi_rescan_device(&sdev->sdev_gendev);
 		envp[idx++] = "SDEV_UA=INQUIRY_DATA_HAS_CHANGED";
 		break;
 	case SDEV_EVT_CAPACITY_CHANGE_REPORTED:
diff --git a/drivers/scsi/scsi_scan.c b/drivers/scsi/scsi_scan.c
index af60709..4d61604 100644
--- a/drivers/scsi/scsi_scan.c
+++ b/drivers/scsi/scsi_scan.c
@@ -43,6 +43,7 @@
 #include <scsi/scsi_devinfo.h>
 #include <scsi/scsi_host.h>
 #include <scsi/scsi_transport.h>
+#include <scsi/scsi_dh.h>
 #include <scsi/scsi_eh.h>
 
 #include "scsi_priv.h"
@@ -1519,9 +1520,14 @@ EXPORT_SYMBOL(scsi_add_device);
 
 void scsi_rescan_device(struct device *dev)
 {
+	struct scsi_device *sdev = to_scsi_device(dev);
+
 	device_lock(dev);
 
-	scsi_attach_vpd(to_scsi_device(dev));
+	scsi_attach_vpd(sdev);
+
+	if (sdev->handler && sdev->handler->rescan)
+		sdev->handler->rescan(sdev);
 
 	if (dev->driver && try_module_get(dev->driver->owner)) {
 		struct scsi_driver *drv = to_scsi_driver(dev->driver);
diff --git a/include/scsi/scsi_dh.h b/include/scsi/scsi_dh.h
index 7e184c6..c7bba2b 100644
--- a/include/scsi/scsi_dh.h
+++ b/include/scsi/scsi_dh.h
@@ -71,6 +71,7 @@ struct scsi_device_handler {
 	int (*activate)(struct scsi_device *, activate_complete, void *);
 	int (*prep_fn)(struct scsi_device *, struct request *);
 	int (*set_params)(struct scsi_device *, const char *);
+	void (*rescan)(struct scsi_device *);
 };
 
 #ifdef CONFIG_SCSI_DH
-- 
1.8.5.6


  parent reply	other threads:[~2016-01-19  8:22 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-01-19  8:21 [PATCHv4 00/23] ALUA device handler update, part II Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 01/23] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 02/23] scsi_dh_alua: separate out alua_stpg() Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 03/23] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 04/23] scsi_dh_alua: call alua_rtpg() if stpg fails Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 05/23] scsi_dh_alua: switch to scsi_execute_req_flags() Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 06/23] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 07/23] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 08/23] scsi_dh_alua: use unique device id Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 09/23] scsi_dh_alua: simplify alua_initialize() Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 10/23] revert commit a8e5a2d593cb ("[SCSI] scsi_dh_alua: ALUA handler attach should succeed while TPG is transitioning") Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 11/23] scsi_dh_alua: move optimize_stpg evaluation Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 12/23] scsi_dh_alua: remove 'rel_port' from alua_dh_data structure Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 13/23] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2016-02-02  9:32   ` Christoph Hellwig
2016-01-19  8:21 ` [PATCHv4 14/23] scsi_dh_alua: Allow workqueue to run synchronously Hannes Reinecke
2016-01-19  8:21 ` [PATCHv4 15/23] scsi_dh_alua: Add new blacklist flag 'BLIST_SYNC_ALUA' Hannes Reinecke
2016-02-02  9:32   ` Christoph Hellwig
2016-01-19  8:22 ` [PATCHv4 16/23] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2016-01-19  8:22 ` [PATCHv4 17/23] scsi_dh_alua: update all port states Hannes Reinecke
2016-01-19  8:22 ` [PATCHv4 18/23] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2016-01-19  8:22 ` Hannes Reinecke [this message]
2016-01-19  8:22 ` [PATCHv4 20/23] scsi: Add 'access_state' attribute Hannes Reinecke
2016-01-19  8:22 ` [PATCHv4 21/23] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2016-01-19  8:22 ` [PATCHv4 22/23] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2016-02-02 18:16   ` Christoph Hellwig
2016-01-19  8:22 ` [PATCHv4 23/23] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
2016-02-02  2:35 ` [PATCHv4 00/23] ALUA device handler update, part II Martin K. Petersen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1453191727-3626-20-git-send-email-hare@suse.de \
    --to=hare@suse.de \
    --cc=bart.vanassche@sandisk.com \
    --cc=emilne@redhat.com \
    --cc=hch@infradead.org \
    --cc=james.bottomley@hansenpartnership.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).