From: Oliver Neukum <oneukum@suse.com>
To: Charles Chiou <ch1102chiou@gmail.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
Christoph Hellwig <hch@infradead.org>,
JBottomley@parallels.com, grace.chang@tw.promise.com,
linus.chen@tw.promise.com, victor.p@promise.com,
linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org,
eva.cheng@tw.promise.com
Subject: Re: [Resend PATCH 3/3] scsi:stex.c Add S3/S4 support
Date: Thu, 04 Feb 2016 12:37:25 +0100 [thread overview]
Message-ID: <1454585845.16206.2.camel@suse.com> (raw)
In-Reply-To: <56B33493.80300@gmail.com>
On Thu, 2016-02-04 at 19:22 +0800, Charles Chiou wrote:
> +static int stex_choice_sleep_mic(pm_message_t state)
> +{
> + switch (state.event) {
> + case PM_EVENT_SUSPEND:
> + return ST_S3;
> + case PM_EVENT_FREEZE:
Why do you react to PM_EVENT_FREEZE at all?
That is too early. You will get a HIBERNATE
event anyway. If the write out fails you are
in trouble if you already reacted to
PM_EVENT_FREEZE
Regards
Oliver
next prev parent reply other threads:[~2016-02-04 11:37 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-03 12:39 [PATCH 3/3] scsi:stex.c Add S3/S4 support Charles Chiou
2015-09-03 14:03 ` Johannes Thumshirn
2016-01-29 11:23 ` Charles Chiou
2016-02-04 11:22 ` [Resend PATCH " Charles Chiou
2016-02-04 11:37 ` Oliver Neukum [this message]
2016-02-22 2:38 ` Charles Chiou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454585845.16206.2.camel@suse.com \
--to=oneukum@suse.com \
--cc=JBottomley@parallels.com \
--cc=ch1102chiou@gmail.com \
--cc=eva.cheng@tw.promise.com \
--cc=grace.chang@tw.promise.com \
--cc=hch@infradead.org \
--cc=jthumshirn@suse.de \
--cc=linus.chen@tw.promise.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=victor.p@promise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).