From: Hannes Reinecke <hare@suse.de>
To: "Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Christoph Hellwig <hch@lst.de>,
Bart van Assche <bart.vanassche@sandisk.com>,
James Bottomley <james.bottomley@hansenpartnership.com>,
linux-scsi@vger.kernel.org, Ewan Milne <emilne@redhat.com>,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH 04/23] scsi_dh_alua: call alua_rtpg() if stpg fails
Date: Mon, 8 Feb 2016 15:34:27 +0100 [thread overview]
Message-ID: <1454942086-128704-5-git-send-email-hare@suse.de> (raw)
In-Reply-To: <1454942086-128704-1-git-send-email-hare@suse.de>
If the call to SET TARGET PORT GROUPS fails we have no idea what
state the array is left in, so we need to issue a call to
REPORT TARGET PORT GROUPS in these cases.
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
drivers/scsi/device_handler/scsi_dh_alua.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/scsi/device_handler/scsi_dh_alua.c b/drivers/scsi/device_handler/scsi_dh_alua.c
index 584e1cf..78cccad 100644
--- a/drivers/scsi/device_handler/scsi_dh_alua.c
+++ b/drivers/scsi/device_handler/scsi_dh_alua.c
@@ -676,6 +676,8 @@ static int alua_activate(struct scsi_device *sdev,
h->flags |= ALUA_OPTIMIZE_STPG;
err = alua_stpg(sdev, h);
+ if (err == SCSI_DH_RETRY)
+ err = alua_rtpg(sdev, h, 1);
out:
if (fn)
fn(data, err);
--
1.8.5.6
next prev parent reply other threads:[~2016-02-08 14:34 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-08 14:34 [PATCH 00/23] ALUA device handler update, part II Hannes Reinecke
2016-02-08 14:34 ` [PATCH 01/23] scsi_dh_alua: Pass buffer as function argument Hannes Reinecke
2016-02-08 14:34 ` [PATCH 02/23] scsi_dh_alua: separate out alua_stpg() Hannes Reinecke
2016-02-11 23:54 ` Bart Van Assche
2016-02-08 14:34 ` [PATCH 03/23] scsi_dh_alua: Make stpg synchronous Hannes Reinecke
2016-02-08 14:34 ` Hannes Reinecke [this message]
2016-02-08 14:34 ` [PATCH 05/23] scsi_dh_alua: switch to scsi_execute_req_flags() Hannes Reinecke
2016-02-08 14:34 ` [PATCH 06/23] scsi_dh_alua: allocate RTPG buffer separately Hannes Reinecke
2016-02-08 14:34 ` [PATCH 07/23] scsi_dh_alua: Use separate alua_port_group structure Hannes Reinecke
2016-02-08 14:34 ` [PATCH 08/23] scsi_dh_alua: use unique device id Hannes Reinecke
2016-02-08 14:34 ` [PATCH 09/23] scsi_dh_alua: simplify alua_initialize() Hannes Reinecke
2016-02-08 14:34 ` [PATCH 10/23] revert commit a8e5a2d593cb ("[SCSI] scsi_dh_alua: ALUA handler attach should succeed while TPG is transitioning") Hannes Reinecke
2016-02-08 14:34 ` [PATCH 11/23] scsi_dh_alua: move optimize_stpg evaluation Hannes Reinecke
2016-02-08 14:34 ` [PATCH 12/23] scsi_dh_alua: remove 'rel_port' from alua_dh_data structure Hannes Reinecke
2016-02-08 14:34 ` [PATCH 13/23] scsi_dh_alua: Use workqueue for RTPG Hannes Reinecke
2016-02-09 12:54 ` Christoph Hellwig
2016-02-08 14:34 ` [PATCH 14/23] scsi_dh_alua: Allow workqueue to run synchronously Hannes Reinecke
2016-02-08 14:34 ` [PATCH 15/23] scsi_dh_alua: Add new blacklist flag 'BLIST_SYNC_ALUA' Hannes Reinecke
2016-02-08 14:34 ` [PATCH 16/23] scsi_dh_alua: Recheck state on unit attention Hannes Reinecke
2016-02-08 14:34 ` [PATCH 17/23] scsi_dh_alua: update all port states Hannes Reinecke
2016-02-08 14:34 ` [PATCH 18/23] scsi_dh_alua: Send TEST UNIT READY to poll for transitioning Hannes Reinecke
2016-02-11 20:25 ` Ewan Milne
2016-02-12 7:12 ` Hannes Reinecke
2016-02-08 14:34 ` [PATCH 19/23] scsi_dh: add 'rescan' callback Hannes Reinecke
2016-02-11 20:27 ` Ewan Milne
2016-02-12 7:14 ` Hannes Reinecke
2016-02-08 14:34 ` [PATCH 20/23] scsi: Add 'access_state' attribute Hannes Reinecke
2016-02-11 20:33 ` Ewan Milne
2016-02-12 7:16 ` Hannes Reinecke
2016-02-08 14:34 ` [PATCH 21/23] scsi_dh_alua: use common definitions for ALUA state Hannes Reinecke
2016-02-08 14:34 ` [PATCH 22/23] scsi_dh_alua: update 'access_state' field Hannes Reinecke
2016-02-09 12:56 ` Christoph Hellwig
2016-02-11 20:37 ` Ewan Milne
2016-02-12 7:20 ` Hannes Reinecke
2016-02-08 14:34 ` [PATCH 23/23] scsi_dh_alua: Update version to 2.0 Hannes Reinecke
2016-02-08 14:37 ` [PATCH 00/23] ALUA device handler update, part II Hannes Reinecke
2016-02-08 19:39 ` Bart Van Assche
2016-02-11 1:37 ` Martin K. Petersen
2016-02-11 17:41 ` Bart Van Assche
2016-02-11 21:24 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1454942086-128704-5-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=bart.vanassche@sandisk.com \
--cc=emilne@redhat.com \
--cc=hch@lst.de \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).