From: Lars-Peter Clausen <lars@metafoo.de>
To: "James E.J. Bottomley" <JBottomley@odin.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>
Cc: Sathya Prakash <sathya.prakash@broadcom.com>,
Chaitra P B <chaitra.basappa@broadcom.com>,
Suganath Prabu Subramani <suganath-prabu.subramani@broadcom.com>,
Jitendra Bhivare <jitendra.bhivare@broadcom.com>,
linux-scsi@vger.kernel.org, MPT-FusionLinux.pdl@broadcom.com,
Lars-Peter Clausen <lars@metafoo.de>
Subject: [PATCH resend 2/2] mpt3sas: Remove unnecessary synchronize_irq() before free_irq()
Date: Fri, 4 Mar 2016 11:15:07 +0100 [thread overview]
Message-ID: <1457086507-5937-2-git-send-email-lars@metafoo.de> (raw)
In-Reply-To: <1457086507-5937-1-git-send-email-lars@metafoo.de>
Calling synchronize_irq() right before free_irq() is quite useless. On one
hand the IRQ can easily fire again before free_irq() is entered, on the
other hand free_irq() itself calls synchronize_irq() internally (in a race
condition free way), before any state associated with the IRQ is freed.
Patch was generated using the following semantic patch:
// <smpl>
@@
expression irq;
@@
-synchronize_irq(irq);
free_irq(irq, ...);
// </smpl>
Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
---
drivers/scsi/mpt3sas/mpt3sas_base.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/scsi/mpt3sas/mpt3sas_base.c b/drivers/scsi/mpt3sas/mpt3sas_base.c
index 5bbbbf2..e4db5fb 100644
--- a/drivers/scsi/mpt3sas/mpt3sas_base.c
+++ b/drivers/scsi/mpt3sas/mpt3sas_base.c
@@ -1820,7 +1820,6 @@ _base_free_irq(struct MPT3SAS_ADAPTER *ioc)
irq_set_affinity_hint(reply_q->vector, NULL);
free_cpumask_var(reply_q->affinity_hint);
}
- synchronize_irq(reply_q->vector);
free_irq(reply_q->vector, reply_q);
kfree(reply_q);
}
--
2.1.4
next prev parent reply other threads:[~2016-03-04 10:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-04 10:15 [PATCH resend 1/2] be2iscsi: Remove unnecessary synchronize_irq() before free_irq() Lars-Peter Clausen
2016-03-04 10:15 ` Lars-Peter Clausen [this message]
2016-03-08 2:05 ` [PATCH resend 2/2] mpt3sas: " Martin K. Petersen
2016-03-09 1:52 ` Martin K. Petersen
2016-03-09 13:26 ` Sreekanth Reddy
2016-03-10 1:43 ` Martin K. Petersen
2016-03-07 2:29 ` [PATCH resend 1/2] be2iscsi: " Jitendra Bhivare
2016-03-08 2:07 ` Martin K. Petersen
-- strict thread matches above, loose matches on Subject: below --
2016-02-02 20:02 Lars-Peter Clausen
2016-02-02 20:02 ` [PATCH resend 2/2] mpt3sas: " Lars-Peter Clausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1457086507-5937-2-git-send-email-lars@metafoo.de \
--to=lars@metafoo.de \
--cc=JBottomley@odin.com \
--cc=MPT-FusionLinux.pdl@broadcom.com \
--cc=chaitra.basappa@broadcom.com \
--cc=jitendra.bhivare@broadcom.com \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sathya.prakash@broadcom.com \
--cc=suganath-prabu.subramani@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).