From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linux-kernel@vger.kernel.org
Cc: Paul Gortmaker <paul.gortmaker@windriver.com>,
Geert Uytterhoeven <geert@linux-m68k.org>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
Thomas Bogendoerfer <tsbogend@alpha.franken.de>,
linux-m68k@vger.kernel.org, linux-mips@linux-mips.org,
linux-scsi@vger.kernel.org
Subject: [PATCH 0/2] scsi: remove orphaned modular code from non-modular drivers
Date: Sun, 27 Mar 2016 13:00:23 -0400 [thread overview]
Message-ID: <1459098025-26269-1-git-send-email-paul.gortmaker@windriver.com> (raw)
In the ongoing audit/cleanup of non-modular code needlessly using modular
infrastructure, the SCSI subsystem fortunately only contains two instances
that I detected. Both are for legacy drivers that predate the git epoch,
so cleary there is no demand for converting these drivers to be tristate.
For anyone new to the underlying goal of this cleanup, we are trying to
not use module support for code that isn't buildable as a module since:
(1) it is easy to accidentally write unused module_exit and remove code
(2) it can be misleading when reading the source, thinking it can be
modular when the Makefile and/or Kconfig prohibit it
(3) it requires the include of the module.h header file which in turn
includes nearly everything else, thus adding to CPP overhead.
(4) it gets copied/replicated into other code and spreads like weeds.
Build tested for mips (jazz) and m68k (sun3x) on 4.6-rc1 to ensure no
silly typos crept in.
---
Cc: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>
Cc: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Cc: linux-m68k@lists.linux-m68k.org
Cc: linux-mips@linux-mips.org
Cc: linux-scsi@vger.kernel.org
Paul Gortmaker (2):
drivers/scsi: make jazz_esp.c driver explicitly non-modular
drivers/scsi: make sun3x_esp.c driver explicitly non-modular
drivers/scsi/jazz_esp.c | 43 ++++++-------------------------------------
drivers/scsi/sun3x_esp.c | 44 +++++---------------------------------------
2 files changed, 11 insertions(+), 76 deletions(-)
--
2.6.1
next reply other threads:[~2016-03-27 17:01 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-27 17:00 Paul Gortmaker [this message]
2016-03-27 17:00 ` [PATCH 1/2] drivers/scsi: make jazz_esp.c driver explicitly non-modular Paul Gortmaker
2016-03-27 17:00 ` [PATCH 2/2] drivers/scsi: make sun3x_esp.c " Paul Gortmaker
2016-03-28 5:31 ` [PATCH 0/2] scsi: remove orphaned modular code from non-modular drivers James Bottomley
2016-03-28 15:10 ` Paul Gortmaker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1459098025-26269-1-git-send-email-paul.gortmaker@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=geert@linux-m68k.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-scsi@vger.kernel.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox