From: Leonid Moiseichuk <leonid.moiseichuk@gmail.com>
To: jejb@linux.vnet.ibm.com, yuxiangl@marvell.com
Cc: Wilfried.Weissmann@gmx.at, dan.j.williams@intel.com,
andy.shevchenko@gmail.com, linux-scsi@vger.kernel.org,
linux-kernel@vger.kernel.org,
Leonid Moiseichuk <leonid.moiseichuk@gmail.com>
Subject: [PATCH v3] mvsas: Generalize Marvell 9485 in pci_device_id
Date: Thu, 7 Apr 2016 21:52:25 +0300 [thread overview]
Message-ID: <1460055145-30467-1-git-send-email-leonid.moiseichuk@gmail.com> (raw)
For generic subvendor has sense to use generic subdevice.
If subdevice ID not equal to 0x9480/0x9485 mvsas will be not activated.
Tested on ASUS P9A-I/C2550/SAS/4L which uses vendor-specific 1043:8635.
v3: add comment and changelog according to Andy's findings
v2: re-phrased commit message
Signed-off-by: Leonid Moiseichuk <leonid.moiseichuk@gmail.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
---
drivers/scsi/mvsas/mv_init.c | 19 +------------------
1 file changed, 1 insertion(+), 18 deletions(-)
diff --git a/drivers/scsi/mvsas/mv_init.c b/drivers/scsi/mvsas/mv_init.c
index c7c250519c4b..8280046fd1f0 100644
--- a/drivers/scsi/mvsas/mv_init.c
+++ b/drivers/scsi/mvsas/mv_init.c
@@ -704,24 +704,7 @@ static struct pci_device_id mvs_pci_table[] = {
.class_mask = 0,
.driver_data = chip_9445,
},
- {
- .vendor = PCI_VENDOR_ID_MARVELL_EXT,
- .device = 0x9485,
- .subvendor = PCI_ANY_ID,
- .subdevice = 0x9480,
- .class = 0,
- .class_mask = 0,
- .driver_data = chip_9485,
- },
- {
- .vendor = PCI_VENDOR_ID_MARVELL_EXT,
- .device = 0x9485,
- .subvendor = PCI_ANY_ID,
- .subdevice = 0x9485,
- .class = 0,
- .class_mask = 0,
- .driver_data = chip_9485,
- },
+ { PCI_VDEVICE(MARVELL_EXT, 0x9485), chip_9485 }, /* Marvell 9480/9485 (any vendor/model) */
{ PCI_VDEVICE(OCZ, 0x1021), chip_9485}, /* OCZ RevoDrive3 */
{ PCI_VDEVICE(OCZ, 0x1022), chip_9485}, /* OCZ RevoDrive3/zDriveR4 (exact model unknown) */
{ PCI_VDEVICE(OCZ, 0x1040), chip_9485}, /* OCZ RevoDrive3/zDriveR4 (exact model unknown) */
--
2.8.0.rc3
next reply other threads:[~2016-04-07 18:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-04-07 18:52 Leonid Moiseichuk [this message]
2016-04-12 2:14 ` [PATCH v3] mvsas: Generalize Marvell 9485 in pci_device_id Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1460055145-30467-1-git-send-email-leonid.moiseichuk@gmail.com \
--to=leonid.moiseichuk@gmail.com \
--cc=Wilfried.Weissmann@gmx.at \
--cc=andy.shevchenko@gmail.com \
--cc=dan.j.williams@intel.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=yuxiangl@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).