* [PATCH] [SCSI] csiostor: Do not use sizeof on pointer type
@ 2016-04-28 16:32 Vaishali Thakkar
0 siblings, 0 replies; only message in thread
From: Vaishali Thakkar @ 2016-04-28 16:32 UTC (permalink / raw)
To: jejb; +Cc: naresh, martin.petersen, linux-scsi, linux-kernel,
Vaishali Thakkar
When sizeof is applied to a pointer typed expression, it gives
the size of the pointer. So, here do not use sizeof on pointer
type.
Problem found using Coccinelle.
Fixes: a3667aaed569 ('[SCSI] csiostor: Chelsio FCoE offload driver')
Signed-off-by: Vaishali Thakkar <vaishali.thakkar@oracle.com>
---
drivers/scsi/csiostor/csio_mb.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/scsi/csiostor/csio_mb.c b/drivers/scsi/csiostor/csio_mb.c
index 9451787..a736de0 100644
--- a/drivers/scsi/csiostor/csio_mb.c
+++ b/drivers/scsi/csiostor/csio_mb.c
@@ -1534,7 +1534,7 @@ csio_mb_isr_handler(struct csio_hw *hw)
* Enqueue event to EventQ. Events processing happens
* in Event worker thread context
*/
- if (csio_enqueue_evt(hw, CSIO_EVT_MBX, mbp, sizeof(mbp)))
+ if (csio_enqueue_evt(hw, CSIO_EVT_MBX, mbp, sizeof(*mbp)))
CSIO_INC_STATS(hw, n_evt_drop);
return 0;
--
2.1.4
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2016-04-28 16:32 UTC | newest]
Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-04-28 16:32 [PATCH] [SCSI] csiostor: Do not use sizeof on pointer type Vaishali Thakkar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).