From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: scsi_common: Modify SMR device type to reflect SCSI specification Date: Sun, 22 May 2016 10:20:43 -0700 Message-ID: <1463937643.2257.19.camel@linux.vnet.ibm.com> References: <1463882319.4525.3.camel@petros-ultrathin> Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: Received: from e36.co.us.ibm.com ([32.97.110.154]:39771 "EHLO e36.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752472AbcEVRUx (ORCPT ); Sun, 22 May 2016 13:20:53 -0400 Received: from localhost by e36.co.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Sun, 22 May 2016 11:20:52 -0600 In-Reply-To: <1463882319.4525.3.camel@petros-ultrathin> Sender: linux-scsi-owner@vger.kernel.org List-Id: linux-scsi@vger.kernel.org To: Petros Koutoupis , martin.petersen@oracle.com, linux-scsi@vger.kernel.org On Sat, 2016-05-21 at 20:58 -0500, Petros Koutoupis wrote: > This change is purely cosmetic but we should adjust device type 0x14 > to reflect the definition given in the SCSI specification standard > (SPC -5). > > Implying Direct-Access assumes that the device supports the > traditional Direct-Access command set when Host Managed Zoned Block > Devices support a subset of that command set with a few zone specific > additions. Please refer to the ZBC for details. This string is output via an sdev_printk. Technically, that makes it a an ABI for stuff that does log parsing. It's only a weak ABI because logs are somewhat changeable so it's not that we can't do this, but I'd like a good reason before doing it. Can you explain why you want do do this? ... your change log is very vague. I think it's because you think we should more closely reflect the language in table 148 (peripheral device type field) but that's not very convincing because none of the rest of our definitions exactly reflect that language either. Plus the current definition reflects how RBC devices are presented, so it seems logical. James