From: Hannes Reinecke <hare@suse.de>
To: Jens Axboe <axboe@kernel.dk>
Cc: Mike Snitzer <snitzer@redhat.com>, Brian King <brking@us.ibm.com>,
linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
Hannes Reinecke <hare@suse.de>
Subject: [PATCH] block: don't check request size in blk_cloned_rq_check_limits()
Date: Mon, 30 May 2016 09:24:53 +0200 [thread overview]
Message-ID: <1464593093-93527-1-git-send-email-hare@suse.de> (raw)
When checking a cloned request there is no need to check
the overall request size; this won't have changed even
when resubmitting to another queue.
Without this patch ppc64le on ibmvfc fails to boot.
Signed-off-by: Hannes Reinecke <hare@suse.de>
---
block/blk-core.c | 5 -----
1 file changed, 5 deletions(-)
diff --git a/block/blk-core.c b/block/blk-core.c
index 2475b1c7..e108bf0 100644
--- a/block/blk-core.c
+++ b/block/blk-core.c
@@ -2160,11 +2160,6 @@ EXPORT_SYMBOL(submit_bio);
static int blk_cloned_rq_check_limits(struct request_queue *q,
struct request *rq)
{
- if (blk_rq_sectors(rq) > blk_queue_get_max_sectors(q, rq->cmd_flags)) {
- printk(KERN_ERR "%s: over max size limit.\n", __func__);
- return -EIO;
- }
-
/*
* queue's settings related to segment counting like q->bounce_pfn
* may differ from that of other stacking queues.
--
1.8.5.6
next reply other threads:[~2016-05-30 7:24 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-30 7:24 Hannes Reinecke [this message]
2016-06-10 13:19 ` block: don't check request size in blk_cloned_rq_check_limits() Mike Snitzer
2016-06-10 13:30 ` Hannes Reinecke
2016-06-10 14:18 ` Mike Snitzer
2016-06-11 10:05 ` Hannes Reinecke
2016-06-11 2:22 ` Martin K. Petersen
2016-06-11 10:01 ` Hannes Reinecke
2016-06-11 11:06 ` Martin K. Petersen
2016-06-11 13:10 ` Hannes Reinecke
2016-06-13 8:07 ` Christoph Hellwig
2016-06-15 1:39 ` Martin K. Petersen
2016-06-15 2:29 ` Mike Snitzer
2016-06-15 2:32 ` Martin K. Petersen
2016-06-15 6:33 ` Hannes Reinecke
2016-06-15 10:03 ` Jens Axboe
2016-06-15 10:33 ` Hannes Reinecke
2016-06-15 16:34 ` Brian King
2016-06-16 12:35 ` Mauricio Faria de Oliveira
2016-06-16 21:59 ` Mauricio Faria de Oliveira
2016-06-17 6:59 ` Hannes Reinecke
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464593093-93527-1-git-send-email-hare@suse.de \
--to=hare@suse.de \
--cc=axboe@kernel.dk \
--cc=brking@us.ibm.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=snitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).