From: "Ewan D. Milne" <emilne@redhat.com>
To: Tom Yan <tom.ty89@gmail.com>
Cc: Johannes Thumshirn <jthumshirn@suse.de>,
"linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: Re: [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist
Date: Fri, 03 Jun 2016 15:19:31 -0400 [thread overview]
Message-ID: <1464981571.20724.84.camel@localhost.localdomain> (raw)
In-Reply-To: <CAGnHSE=PA-2CR3T-q1JEvXrOFAVFfmVMQaTcf=i6LwVf0hEo6w@mail.gmail.com>
commit 09e2b0b14690fb13ccfc04af49f156df3e25b152
Author: Hannes Reinecke <hare@suse.de>
Date: Mon Nov 9 13:24:28 2015 +0100
scsi: rescan VPD attributes
---
see also:
commit 5ddfe0858ea7848c5d4efe3f4319e7543522e0ee
Author: Hannes Reinecke <hare@suse.de>
Date: Fri Apr 1 08:57:36 2016 +0200
scsi: Do not attach VPD to devices that don't support it
commit 82c43310508eb19eb41fe7862e89afeb74030b84
Author: Mika Westerberg <mika.westerberg@linux.intel.com>
Date: Wed Jan 27 16:19:13 2016 +0200
SCSI: Add Marvell Console to VPD blacklist
and presumably:
commit fb2d65d28918ef4f0caa1de3d8c7416949c28b41
Author: Todd Fujinaka <todd.fujinaka@intel.com>
Date: Tue Feb 9 21:02:07 2016 -0500
SCSI: Add Marvell configuration device to VPD blacklist
On Sat, 2016-06-04 at 03:14 +0800, Tom Yan wrote:
> What changes are you referring to? Doesn't that mean the changes are
> flawed and some actual follow-up fixes are needed instead?
>
> On 3 June 2016 at 22:36, Ewan D. Milne <emilne@redhat.com> wrote:
> > This is an existing configuration that broke with the VPD rescan
> > changes. The problem is that the error causes a rescan to be
> > initiated, which results in endless error messages.
> >
> > On Fri, 2016-06-03 at 03:15 +0000, Tom Yan wrote:
> >> Why not get qemu have it fixed instead?
> >>
> >> On Tuesday, 31 May 2016, Johannes Thumshirn <jthumshirn@suse.de>
> >> wrote:
> >> On Tue, May 31, 2016 at 09:42:29AM -0400, Ewan D. Milne wrote:
> >> > Linux fails to boot as a guest with a QEMU CD-ROM:
> >> >
> >> > [ 4.439488] ata2.00: ATAPI: QEMU CD-ROM, 0.8.2, max
> >> UDMA/100
> >> > [ 4.443649] ata2.00: configured for MWDMA2
> >> > [ 4.450267] scsi 1:0:0:0: CD-ROM QEMU QEMU
> >> CD-ROM 0.8. PQ: 0 ANSI: 5
> >> > [ 4.464317] ata2.00: exception Emask 0x0 SAct 0x0 SErr
> >> 0x0 action 0x6 frozen
> >> > [ 4.464319] ata2.00: BMDMA stat 0x5
> >> > [ 4.464339] ata2.00: cmd
> >> a0/01:00:00:00:01/00:00:00:00:00/a0 tag 0 dma 16640 in
> >> > [ 4.464339] Inquiry 12 01 00 00 ff 00res
> >> 48/20:02:00:24:00/00:00:00:00:00/a0 Emask 0x2 (HSM violation)
> >> > [ 4.464341] ata2.00: status: { DRDY DRQ }
> >> > [ 4.465864] ata2: soft resetting link
> >> > [ 4.625971] ata2.00: configured for MWDMA2
> >> > [ 4.628290] ata2: EH complete
> >> > [ 4.646670] ata2.00: exception Emask 0x0 SAct 0x0 SErr
> >> 0x0 action 0x6 frozen
> >> > [ 4.646671] ata2.00: BMDMA stat 0x5
> >> > [ 4.646683] ata2.00: cmd
> >> a0/01:00:00:00:01/00:00:00:00:00/a0 tag 0 dma 16640 in
> >> > [ 4.646683] Inquiry 12 01 00 00 ff 00res
> >> 48/20:02:00:24:00/00:00:00:00:00/a0 Emask 0x2 (HSM violation)
> >> > [ 4.646685] ata2.00: status: { DRDY DRQ }
> >> > [ 4.648193] ata2: soft resetting link
> >> >
> >> > ...
> >> >
> >> > Fix this by suppressing VPD inquiry for this device.
> >> >
> >> > Reported-by: Jan Stancek <jstancek@redhat.com>
> >> > Tested-by: Jan Stancek <jstancek@redhat.com>
> >> > Cc: <stable@vger.kernel.org>
> >> > Signed-off-by: Ewan D. Milne <emilne@redhat.com>
> >>
> >> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> >>
> >> --
> >> Johannes Thumshirn
> >> Storage
> >> jthumshirn@suse.de +49 911
> >> 74053 689
> >> SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
> >> GF: Felix Imendörffer, Jane Smithard, Graham Norton
> >> HRB 21284 (AG Nürnberg)
> >> Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76
> >> 0850
> >> --
> >> To unsubscribe from this list: send the line "unsubscribe
> >> linux-scsi" in
> >> the body of a message to majordomo@vger.kernel.org
> >> More majordomo info at
> >> http://vger.kernel.org/majordomo-info.html
> >
> >
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2016-06-03 19:19 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 13:42 [PATCH] scsi: Add QEMU CD-ROM to VPD Inquiry Blacklist Ewan D. Milne
2016-05-31 13:43 ` Johannes Thumshirn
2016-06-03 3:19 ` Tom Yan
[not found] ` <CAGnHSEmS7NzEFK7uD357r6Y=xU5o1O0i+AU5qhmqcqjmp_K0Lw@mail.gmail.com>
2016-06-03 14:36 ` Ewan D. Milne
2016-06-03 19:14 ` Tom Yan
2016-06-03 19:19 ` Ewan D. Milne [this message]
2016-06-03 21:14 ` Bart Van Assche
2016-06-06 7:34 ` Hannes Reinecke
2016-06-06 14:11 ` Ewan D. Milne
2016-06-06 14:22 ` Hannes Reinecke
2016-06-06 15:05 ` Paolo Bonzini
2016-06-06 15:41 ` John Snow
2016-06-06 15:43 ` Paolo Bonzini
2016-06-06 15:47 ` John Snow
2016-06-06 16:03 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464981571.20724.84.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=tom.ty89@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).