From: "Ewan D. Milne" <emilne@redhat.com>
To: Hannes Reinecke <hare@suse.de>
Cc: linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH 1/3] scsi: Move 'scsi_attach_vpd()' prototype to scsi_priv.h
Date: Mon, 20 Jun 2016 09:24:46 -0400 [thread overview]
Message-ID: <1466429086.4039.14.camel@localhost.localdomain> (raw)
In-Reply-To: <1466405868-87720-2-git-send-email-hare@suse.de>
On Mon, 2016-06-20 at 08:57 +0200, Hannes Reinecke wrote:
> scsi_attach_vpd() is not exported, so it should be in scsi_priv.h.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
> drivers/scsi/scsi_priv.h | 1 +
> include/scsi/scsi_device.h | 1 -
> 2 files changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/scsi_priv.h b/drivers/scsi/scsi_priv.h
> index 57a4b99..6c3db56 100644
> --- a/drivers/scsi/scsi_priv.h
> +++ b/drivers/scsi/scsi_priv.h
> @@ -31,6 +31,7 @@ extern void scsi_exit_hosts(void);
> /* scsi.c */
> extern int scsi_setup_command_freelist(struct Scsi_Host *shost);
> extern void scsi_destroy_command_freelist(struct Scsi_Host *shost);
> +void scsi_attach_vpd(struct scsi_device *sdev);
> #ifdef CONFIG_SCSI_LOGGING
> void scsi_log_send(struct scsi_cmnd *cmd);
> void scsi_log_completion(struct scsi_cmnd *cmd, int disposition);
> diff --git a/include/scsi/scsi_device.h b/include/scsi/scsi_device.h
> index a6c346d..3f2f147 100644
> --- a/include/scsi/scsi_device.h
> +++ b/include/scsi/scsi_device.h
> @@ -314,7 +314,6 @@ extern int scsi_add_device(struct Scsi_Host *host, uint channel,
> extern int scsi_register_device_handler(struct scsi_device_handler *scsi_dh);
> extern void scsi_remove_device(struct scsi_device *);
> extern int scsi_unregister_device_handler(struct scsi_device_handler *scsi_dh);
> -void scsi_attach_vpd(struct scsi_device *sdev);
>
> extern int scsi_device_get(struct scsi_device *);
> extern void scsi_device_put(struct scsi_device *);
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
next prev parent reply other threads:[~2016-06-20 13:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-20 6:57 [PATCH 0/3] VPD page check consolidation Hannes Reinecke
2016-06-20 6:57 ` [PATCH 1/3] scsi: Move 'scsi_attach_vpd()' prototype to scsi_priv.h Hannes Reinecke
2016-06-20 13:24 ` Ewan D. Milne [this message]
2016-06-22 13:22 ` Christoph Hellwig
2016-06-20 6:57 ` [PATCH 2/3] scsi: disable VPD page check on error Hannes Reinecke
2016-06-20 13:25 ` Ewan D. Milne
2016-06-20 13:44 ` James Bottomley
2016-06-20 15:03 ` Ewan D. Milne
2016-06-22 2:54 ` Martin K. Petersen
2016-06-22 13:23 ` Christoph Hellwig
2016-06-20 6:57 ` [PATCH 3/3] scsi: consolidate checking for VPD pages Hannes Reinecke
2016-06-20 13:26 ` Ewan D. Milne
2016-06-22 13:24 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1466429086.4039.14.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).