public inbox for linux-scsi@vger.kernel.org
 help / color / mirror / Atom feed
From: Markus Mayer <mmayer@broadcom.com>
To: Nicholas Bellinger <nab@linux-iscsi.org>,
	Roland Dreier <roland@purestorage.com>,
	Varun Prakash <varun@chelsio.com>
Cc: Markus Mayer <mmayer@broadcom.com>,
	linux-scsi@vger.kernel.org, target-devel@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: [PATCH v3 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower()
Date: Fri,  8 Jul 2016 15:43:12 -0700	[thread overview]
Message-ID: <1468017794-4818-6-git-send-email-mmayer@broadcom.com> (raw)
In-Reply-To: <1468017794-4818-1-git-send-email-mmayer@broadcom.com>

After introducing generic strtolower(), iscsi_initiatorname_tolower() is
no longer needed.

Signed-off-by: Markus Mayer <mmayer@broadcom.com>
---
 drivers/target/iscsi/iscsi_target_nego.c | 17 +----------------
 1 file changed, 1 insertion(+), 16 deletions(-)

diff --git a/drivers/target/iscsi/iscsi_target_nego.c b/drivers/target/iscsi/iscsi_target_nego.c
index 89d34bd..fa20638 100644
--- a/drivers/target/iscsi/iscsi_target_nego.c
+++ b/drivers/target/iscsi/iscsi_target_nego.c
@@ -987,21 +987,6 @@ static int iscsi_target_do_login(struct iscsi_conn *conn, struct iscsi_login *lo
 	return 0;
 }
 
-static void iscsi_initiatorname_tolower(
-	char *param_buf)
-{
-	char *c;
-	u32 iqn_size = strlen(param_buf), i;
-
-	for (i = 0; i < iqn_size; i++) {
-		c = &param_buf[i];
-		if (!isupper(*c))
-			continue;
-
-		*c = tolower(*c);
-	}
-}
-
 /*
  * Processes the first Login Request..
  */
@@ -1075,7 +1060,7 @@ int iscsi_target_locate_portal(
 	 * RFC-3720 3.2.6.1. section c) that says that iSCSI IQNs
 	 * are NOT case sensitive.
 	 */
-	iscsi_initiatorname_tolower(i_buf);
+	strtolower(i_buf);
 
 	if (!s_buf) {
 		if (!login->leading_connection)
-- 
2.7.4

  parent reply	other threads:[~2016-07-08 22:43 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-08 22:43 [PATCH v3 0/7] lib: string: add functions to case-convert strings Markus Mayer
     [not found] ` <1468017794-4818-1-git-send-email-mmayer-dY08KVG/lbpWk0Htik3J/w@public.gmane.org>
2016-07-08 22:43   ` [PATCH v3 1/7] " Markus Mayer
2016-07-09 12:04     ` Luis de Bethencourt
     [not found]       ` <5780E866.8000001-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-07-09 15:30         ` Markus Mayer
     [not found]           ` <CAGt4E5vYzkqgiiQXXjnX7az-KzCVSYthEW5Df03U=Y1qhEJdRQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-11 22:46             ` Markus Mayer
     [not found]               ` <CAGt4E5tpw0sa1PQmgJzKbPuzSbFG9_CUWjjO1z93OSc0KkjUXw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-13 17:19                 ` Luis de Bethencourt
     [not found]                   ` <57867813.8010608-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-07-13 22:26                     ` Markus Mayer
     [not found]                       ` <CAGt4E5tRcYQeWdTLvABjpd2WgAPLmdrdEUVK33pS0J3a06wJ5w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-13 22:53                         ` Luis de Bethencourt
     [not found]                           ` <5786C665.6020307-JPH+aEBZ4P+UEJcrhfAQsw@public.gmane.org>
2016-07-13 23:04                             ` Markus Mayer
2016-07-08 22:43 ` Markus Mayer [this message]
2016-07-20 21:16   ` [PATCH v3 5/7] iscsi-target: replace iscsi_initiatorname_tolower() with strtolower() Nicholas A. Bellinger
2016-07-20 21:17     ` Nicholas A. Bellinger
2016-07-20 21:19       ` Markus Mayer
2016-07-10  3:13 ` [PATCH v3 0/7] lib: string: add functions to case-convert strings Chris Metcalf
     [not found]   ` <9b88baed-a067-fcfd-d087-66e36f3060d7-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
2016-07-10  4:11     ` Markus Mayer
     [not found]       ` <CAGt4E5t0TGMxiUfV5Mx+EGyAYAmTOCEJe4QxjpjujvZfPwvYuQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2016-07-13 22:52         ` Markus Mayer
     [not found]           ` <20160713225236.GA30571-opzSsqMRwNylyEujtbL6/5Ym1tgvmhRUMm0uRHvK7Nw@public.gmane.org>
2016-07-20 20:28             ` Markus Mayer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1468017794-4818-6-git-send-email-mmayer@broadcom.com \
    --to=mmayer@broadcom.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=nab@linux-iscsi.org \
    --cc=roland@purestorage.com \
    --cc=target-devel@vger.kernel.org \
    --cc=varun@chelsio.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox