From: "Ewan D. Milne" <emilne@redhat.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: linux-scsi@vger.kernel.org
Subject: Re: [patch] ibmvfc: prevent a potential deadlock
Date: Fri, 15 Jul 2016 11:06:05 -0400 [thread overview]
Message-ID: <1468595165.4064.44.camel@localhost.localdomain> (raw)
In-Reply-To: <20160715111857.GC13153@mwanda>
On Fri, 2016-07-15 at 14:18 +0300, Dan Carpenter wrote:
> My static checker complains that we need to unlock on this path. Seems
> true.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
> diff --git a/drivers/scsi/ibmvscsi/ibmvfc.c b/drivers/scsi/ibmvscsi/ibmvfc.c
> index fc523c3..ab67ec4 100644
> --- a/drivers/scsi/ibmvscsi/ibmvfc.c
> +++ b/drivers/scsi/ibmvscsi/ibmvfc.c
> @@ -4722,6 +4722,8 @@ static void ibmvfc_rport_add_thread(struct work_struct *work)
> tgt_dbg(tgt, "Setting rport roles\n");
> fc_remote_port_rolechg(rport, tgt->ids.roles);
> put_device(&rport->dev);
> + } else {
> + spin_unlock_irqrestore(vhost->host->host_lock, flags);
> }
>
> kref_put(&tgt->kref, ibmvfc_release_tgt);
> --
Reviewed-by: Ewan D. Milne <emilne@redhat.com>
next prev parent reply other threads:[~2016-07-15 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-15 11:18 [patch] ibmvfc: prevent a potential deadlock Dan Carpenter
2016-07-15 13:38 ` Brian King
2016-07-15 15:06 ` Ewan D. Milne [this message]
2016-07-15 19:14 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1468595165.4064.44.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=dan.carpenter@oracle.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox