* [PATCH] tcm_fc: set and unset FCP_SPPF_TARG_FCN
@ 2016-07-19 13:01 Hannes Reinecke
2016-07-20 20:27 ` Nicholas A. Bellinger
0 siblings, 1 reply; 2+ messages in thread
From: Hannes Reinecke @ 2016-07-19 13:01 UTC (permalink / raw)
To: Nicholas A. Bellinger
Cc: target-devel, linux-scsi, Hannes Reinecke, Hannes Reinecke
When registering and unregistering as an target port we should
be setting the FC-4 service params correctly.
Signed-off-by: Hannes Reinecke <hare@suse.com>
---
drivers/target/tcm_fc/tfc_sess.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/target/tcm_fc/tfc_sess.c b/drivers/target/tcm_fc/tfc_sess.c
index f5186a7..6ffbb60 100644
--- a/drivers/target/tcm_fc/tfc_sess.c
+++ b/drivers/target/tcm_fc/tfc_sess.c
@@ -91,6 +91,7 @@ static void ft_tport_delete(struct ft_tport *tport)
ft_sess_delete_all(tport);
lport = tport->lport;
+ lport->service_params &= ~FCP_SPPF_TARG_FCN;
BUG_ON(tport != lport->prov[FC_TYPE_FCP]);
RCU_INIT_POINTER(lport->prov[FC_TYPE_FCP], NULL);
@@ -110,6 +111,7 @@ void ft_lport_add(struct fc_lport *lport, void *arg)
{
mutex_lock(&ft_lport_lock);
ft_tport_get(lport);
+ lport->service_params |= FCP_SPPF_TARG_FCN;
mutex_unlock(&ft_lport_lock);
}
--
1.8.5.6
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] tcm_fc: set and unset FCP_SPPF_TARG_FCN
2016-07-19 13:01 [PATCH] tcm_fc: set and unset FCP_SPPF_TARG_FCN Hannes Reinecke
@ 2016-07-20 20:27 ` Nicholas A. Bellinger
0 siblings, 0 replies; 2+ messages in thread
From: Nicholas A. Bellinger @ 2016-07-20 20:27 UTC (permalink / raw)
To: Hannes Reinecke
Cc: Nicholas A. Bellinger, target-devel, linux-scsi, Hannes Reinecke
On Tue, 2016-07-19 at 15:01 +0200, Hannes Reinecke wrote:
> When registering and unregistering as an target port we should
> be setting the FC-4 service params correctly.
>
> Signed-off-by: Hannes Reinecke <hare@suse.com>
> ---
> drivers/target/tcm_fc/tfc_sess.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/target/tcm_fc/tfc_sess.c b/drivers/target/tcm_fc/tfc_sess.c
> index f5186a7..6ffbb60 100644
> --- a/drivers/target/tcm_fc/tfc_sess.c
> +++ b/drivers/target/tcm_fc/tfc_sess.c
> @@ -91,6 +91,7 @@ static void ft_tport_delete(struct ft_tport *tport)
>
> ft_sess_delete_all(tport);
> lport = tport->lport;
> + lport->service_params &= ~FCP_SPPF_TARG_FCN;
> BUG_ON(tport != lport->prov[FC_TYPE_FCP]);
> RCU_INIT_POINTER(lport->prov[FC_TYPE_FCP], NULL);
>
> @@ -110,6 +111,7 @@ void ft_lport_add(struct fc_lport *lport, void *arg)
> {
> mutex_lock(&ft_lport_lock);
> ft_tport_get(lport);
> + lport->service_params |= FCP_SPPF_TARG_FCN;
> mutex_unlock(&ft_lport_lock);
> }
>
Applied to target-pending/for-next.
Thanks Hannes.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-07-20 20:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-07-19 13:01 [PATCH] tcm_fc: set and unset FCP_SPPF_TARG_FCN Hannes Reinecke
2016-07-20 20:27 ` Nicholas A. Bellinger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).