From: James Bottomley <jejb@linux.vnet.ibm.com>
To: "Martin K. Petersen" <martin.petersen@oracle.com>,
Calvin Owens <calvinowens@fb.com>
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ses: Fix racy cleanup of /sys in remove_dev()
Date: Fri, 12 Aug 2016 10:45:05 -0700 [thread overview]
Message-ID: <1471023905.2407.42.camel@linux.vnet.ibm.com> (raw)
In-Reply-To: <yq1popx2q5t.fsf@sermon.lab.mkp.net>
On Thu, 2016-07-28 at 21:23 -0400, Martin K. Petersen wrote:
> > > > > > "Calvin" == Calvin Owens <calvinowens@fb.com> writes:
>
> > > Any thoughts? Squinting at this more it still seems racy, but a
> > > narrow race is surely better than just blatantly freeing
> > > everything
> > > while the file is still exposed in /sys? Is there a better way
> > > you'd
> > > prefer I accomplish this?
> > >
> > > (I have boxes that OOPS all the time from monitoring code reading
> > > the
> > > /sys files, with this patch I haven't seen a single one.)
>
> Calvin> Ping? Thoughts, comments?
>
> James: This is your puppy...
I thought it would be bigger by now going by the early paw size
indicator ...
Anyway
Reviewed-by: James Bottomley <jejb@linux.vnet.ibm.com>
James
next prev parent reply other threads:[~2016-08-12 17:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-13 20:28 [PATCH] ses: Fix racy cleanup of /sys in remove_dev() Calvin Owens
2016-06-02 22:50 ` Calvin Owens
2016-06-15 20:24 ` Calvin Owens
2016-07-28 1:04 ` Calvin Owens
2016-07-29 1:23 ` Martin K. Petersen
2016-08-12 17:45 ` James Bottomley [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-08-24 13:13 Hannes Reinecke
2017-08-25 21:36 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1471023905.2407.42.camel@linux.vnet.ibm.com \
--to=jejb@linux.vnet.ibm.com \
--cc=calvinowens@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).