From: Daniel Wagner <wagi@monom.org>
To: linux-scsi@vger.kernel.org
Cc: "James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Matthew Wilcox <matthew.r.wilcox@intel.com>,
linux-kernel@vger.kernel.org,
Daniel Wagner <daniel.wagner@bmw-carit.de>
Subject: [PATCH 0/3] wireless: Use complete() instead complete_all()
Date: Tue, 13 Sep 2016 10:58:47 +0200 [thread overview]
Message-ID: <1473757130-14751-1-git-send-email-wagi@monom.org> (raw)
From: Daniel Wagner <daniel.wagner@bmw-carit.de>
Hi,
Using complete_all() is not wrong per se but it suggest that there
might be more than one waiter. For -rt I am reviewing all
complete_all() users and would like to leave only the real ones in the
tree. The main problem for -rt about complete_all() is that it can be
uses inside IRQ context and that can lead to unbounded amount work
inside the interrupt handler. That is a no no for -rt.
The patches grouped per subsystem and in small batches to allow
reviewing.
Patch #1 fixes a minor bug in the completion API usage. The current code
works but it could work better.
cheers,
daniel
Daniel Wagner (3):
csiostor: fix completion usage
sym53c8xx_2: use complete() instead complete_all()
virtio_scsi: use complete() instead complete_all()
drivers/scsi/csiostor/csio_scsi.c | 5 ++---
drivers/scsi/sym53c8xx_2/sym_glue.c | 2 +-
drivers/scsi/virtio_scsi.c | 2 +-
3 files changed, 4 insertions(+), 5 deletions(-)
--
2.7.4
next reply other threads:[~2016-09-13 8:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 8:58 Daniel Wagner [this message]
2016-09-13 8:58 ` [PATCH 1/3] csiostor: fix completion usage Daniel Wagner
2016-09-14 7:26 ` Christoph Hellwig
2016-09-13 8:58 ` [PATCH 2/3] sym53c8xx_2: use complete() instead complete_all() Daniel Wagner
2016-09-14 7:26 ` Christoph Hellwig
2016-09-13 8:58 ` [PATCH 3/3] virtio_scsi: " Daniel Wagner
2016-09-14 7:27 ` Christoph Hellwig
2016-09-14 17:23 ` [PATCH 0/3] wireless: Use " Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473757130-14751-1-git-send-email-wagi@monom.org \
--to=wagi@monom.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=matthew.r.wilcox@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).