From: "Ewan D. Milne" <emilne@redhat.com>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: Hannes Reinecke <hare@suse.de>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
linux-scsi@vger.kernel.org, Hannes Reinecke <hare@suse.com>
Subject: Re: [PATCH] scsi: do not print 'reservation conflict' for TEST UNIT READY
Date: Tue, 13 Sep 2016 15:05:40 -0400 [thread overview]
Message-ID: <1473793540.4648.36.camel@localhost.localdomain> (raw)
In-Reply-To: <1473779178.2214.9.camel@HansenPartnership.com>
On Tue, 2016-09-13 at 08:06 -0700, James Bottomley wrote:
> On Tue, 2016-09-13 at 16:24 +0200, Hannes Reinecke wrote:
> > On 09/13/2016 04:04 PM, James Bottomley wrote:
> > > You could argue that the entire message needs removing, since it's
> > > reporting stuff that mostly only shows when systems using
> > > reservations correctly are in operation.
> > >
> > Oh, I'm perfectly fine with that.
> > I'm happy to send a patch removing that line altogether.
>
> OK, how about lowering the priority to KERN_DEBUG so it can still be
> seen, just not usually.
>
> James
>
So, if we do this, and someone else does a SCSI-2 RESERVE on the LUN
while we have a file system mounted, what error will we end up getting?
I would assume that we would still see the usual SCSI error message
with the CDB printed, and that the "reservation conflict" message was
supplemental? Or does the message get suppressed? I'll have to try
this...
-Ewan
next prev parent reply other threads:[~2016-09-13 19:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-12 8:20 [PATCH] scsi: do not print 'reservation conflict' for TEST UNIT READY Hannes Reinecke
2016-09-12 15:02 ` Laurence Oberman
2016-09-13 14:04 ` James Bottomley
2016-09-13 14:24 ` Hannes Reinecke
2016-09-13 15:06 ` James Bottomley
2016-09-13 19:05 ` Ewan D. Milne [this message]
2016-09-13 19:20 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1473793540.4648.36.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).