* [PATCH] megaraid_sas: clean function declarations in megaraid_sas_base.c up
@ 2016-09-18 12:07 Baoyou Xie
2016-09-19 13:50 ` Sumit Saxena
2016-09-19 16:00 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Baoyou Xie @ 2016-09-18 12:07 UTC (permalink / raw)
To: kashyap.desai, sumit.saxena, uday.lingala, jejb, martin.petersen
Cc: megaraidlinux.pdl, linux-scsi, linux-kernel, arnd, baoyou.xie,
xie.baoyou
We get a few warnings when building kernel with W=1:
drivers/scsi/megaraid/megaraid_sas_fusion.c:281:1: warning: no previous prototype for 'megasas_free_cmds_fusion' [-Wmissing-prototypes]
drivers/scsi/megaraid/megaraid_sas_fusion.c:714:1: warning: no previous prototype for 'megasas_ioc_init_fusion' [-Wmissing-prototypes]
....
In fact, these functions are declared in
drivers/scsi/megaraid/megaraid_sas_base.c, but should
be declared in a header file, thus can be recognized in other file.
So this patch adds the declarations into
drivers/scsi/megaraid/megaraid_sas_fusion.h.
Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
---
drivers/scsi/megaraid/megaraid_sas_base.c | 13 -------------
drivers/scsi/megaraid/megaraid_sas_fusion.h | 9 +++++++++
2 files changed, 9 insertions(+), 13 deletions(-)
diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c b/drivers/scsi/megaraid/megaraid_sas_base.c
index 2d62d71..b73b6f3 100644
--- a/drivers/scsi/megaraid/megaraid_sas_base.c
+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
@@ -189,25 +189,12 @@ u32
megasas_build_and_issue_cmd(struct megasas_instance *instance,
struct scsi_cmnd *scmd);
static void megasas_complete_cmd_dpc(unsigned long instance_addr);
-void
-megasas_release_fusion(struct megasas_instance *instance);
-int
-megasas_ioc_init_fusion(struct megasas_instance *instance);
-void
-megasas_free_cmds_fusion(struct megasas_instance *instance);
-u8
-megasas_get_map_info(struct megasas_instance *instance);
-int
-megasas_sync_map_info(struct megasas_instance *instance);
int
wait_and_poll(struct megasas_instance *instance, struct megasas_cmd *cmd,
int seconds);
-void megasas_reset_reply_desc(struct megasas_instance *instance);
void megasas_fusion_ocr_wq(struct work_struct *work);
static int megasas_get_ld_vf_affiliation(struct megasas_instance *instance,
int initial);
-int megasas_check_mpio_paths(struct megasas_instance *instance,
- struct scsi_cmnd *scmd);
int
megasas_issue_dcmd(struct megasas_instance *instance, struct megasas_cmd *cmd)
diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h b/drivers/scsi/megaraid/megaraid_sas_fusion.h
index 80eaee2..3fe730a 100644
--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
@@ -991,5 +991,14 @@ union desc_value {
} u;
};
+void megasas_free_cmds_fusion(struct megasas_instance *instance);
+int megasas_ioc_init_fusion(struct megasas_instance *instance);
+u8 megasas_get_map_info(struct megasas_instance *instance);
+int megasas_sync_map_info(struct megasas_instance *instance);
+void megasas_release_fusion(struct megasas_instance *instance);
+void megasas_reset_reply_desc(struct megasas_instance *instance);
+int megasas_check_mpio_paths(struct megasas_instance *instance,
+ struct scsi_cmnd *scmd);
+void megasas_fusion_ocr_wq(struct work_struct *work);
#endif /* _MEGARAID_SAS_FUSION_H_ */
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* RE: [PATCH] megaraid_sas: clean function declarations in megaraid_sas_base.c up
2016-09-18 12:07 [PATCH] megaraid_sas: clean function declarations in megaraid_sas_base.c up Baoyou Xie
@ 2016-09-19 13:50 ` Sumit Saxena
2016-09-19 16:00 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Sumit Saxena @ 2016-09-19 13:50 UTC (permalink / raw)
To: Baoyou Xie, kashyap.desai, sumit.saxena, uday.lingala, jejb,
martin.petersen
Cc: megaraidlinux.pdl, linux-scsi, linux-kernel, arnd, xie.baoyou
>-----Original Message-----
>From: Baoyou Xie [mailto:baoyou.xie@linaro.org]
>Sent: Sunday, September 18, 2016 5:38 PM
>To: kashyap.desai@avagotech.com; sumit.saxena@avagotech.com;
>uday.lingala@avagotech.com; jejb@linux.vnet.ibm.com;
>martin.petersen@oracle.com
>Cc: megaraidlinux.pdl@avagotech.com; linux-scsi@vger.kernel.org; linux-
>kernel@vger.kernel.org; arnd@arndb.de; baoyou.xie@linaro.org;
>xie.baoyou@zte.com.cn
>Subject: [PATCH] megaraid_sas: clean function declarations in
>megaraid_sas_base.c up
>
>We get a few warnings when building kernel with W=1:
>drivers/scsi/megaraid/megaraid_sas_fusion.c:281:1: warning: no previous
>prototype for 'megasas_free_cmds_fusion' [-Wmissing-prototypes]
>drivers/scsi/megaraid/megaraid_sas_fusion.c:714:1: warning: no previous
>prototype for 'megasas_ioc_init_fusion' [-Wmissing-prototypes] ....
>
>In fact, these functions are declared in
>drivers/scsi/megaraid/megaraid_sas_base.c, but should be declared in a
header
>file, thus can be recognized in other file.
>
>So this patch adds the declarations into
>drivers/scsi/megaraid/megaraid_sas_fusion.h.
>
>Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
>---
> drivers/scsi/megaraid/megaraid_sas_base.c | 13 -------------
> drivers/scsi/megaraid/megaraid_sas_fusion.h | 9 +++++++++
> 2 files changed, 9 insertions(+), 13 deletions(-)
>
>diff --git a/drivers/scsi/megaraid/megaraid_sas_base.c
>b/drivers/scsi/megaraid/megaraid_sas_base.c
>index 2d62d71..b73b6f3 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_base.c
>+++ b/drivers/scsi/megaraid/megaraid_sas_base.c
>@@ -189,25 +189,12 @@ u32
> megasas_build_and_issue_cmd(struct megasas_instance *instance,
> struct scsi_cmnd *scmd);
> static void megasas_complete_cmd_dpc(unsigned long instance_addr); -void
-
>megasas_release_fusion(struct megasas_instance *instance); -int -
>megasas_ioc_init_fusion(struct megasas_instance *instance); -void -
>megasas_free_cmds_fusion(struct megasas_instance *instance);
>-u8
>-megasas_get_map_info(struct megasas_instance *instance); -int -
>megasas_sync_map_info(struct megasas_instance *instance); int
>wait_and_poll(struct megasas_instance *instance, struct megasas_cmd *cmd,
> int seconds);
>-void megasas_reset_reply_desc(struct megasas_instance *instance); void
>megasas_fusion_ocr_wq(struct work_struct *work); static int
>megasas_get_ld_vf_affiliation(struct megasas_instance *instance,
> int initial);
>-int megasas_check_mpio_paths(struct megasas_instance *instance,
>- struct scsi_cmnd *scmd);
>
> int
> megasas_issue_dcmd(struct megasas_instance *instance, struct megasas_cmd
>*cmd) diff --git a/drivers/scsi/megaraid/megaraid_sas_fusion.h
>b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>index 80eaee2..3fe730a 100644
>--- a/drivers/scsi/megaraid/megaraid_sas_fusion.h
>+++ b/drivers/scsi/megaraid/megaraid_sas_fusion.h
>@@ -991,5 +991,14 @@ union desc_value {
> } u;
> };
>
>+void megasas_free_cmds_fusion(struct megasas_instance *instance); int
>+megasas_ioc_init_fusion(struct megasas_instance *instance);
>+u8 megasas_get_map_info(struct megasas_instance *instance); int
>+megasas_sync_map_info(struct megasas_instance *instance); void
>+megasas_release_fusion(struct megasas_instance *instance); void
>+megasas_reset_reply_desc(struct megasas_instance *instance); int
>+megasas_check_mpio_paths(struct megasas_instance *instance,
>+ struct scsi_cmnd *scmd);
>+void megasas_fusion_ocr_wq(struct work_struct *work);
>
> #endif /* _MEGARAID_SAS_FUSION_H_ */
Acked-by: Sumit Saxena <sumit.saxena@broadcom.com>
>--
>2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] megaraid_sas: clean function declarations in megaraid_sas_base.c up
2016-09-18 12:07 [PATCH] megaraid_sas: clean function declarations in megaraid_sas_base.c up Baoyou Xie
2016-09-19 13:50 ` Sumit Saxena
@ 2016-09-19 16:00 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2016-09-19 16:00 UTC (permalink / raw)
To: Baoyou Xie
Cc: kashyap.desai, sumit.saxena, uday.lingala, jejb, martin.petersen,
megaraidlinux.pdl, linux-scsi, linux-kernel, arnd, xie.baoyou
>>>>> "Baoyou" == Baoyou Xie <baoyou.xie@linaro.org> writes:
Baoyou> We get a few warnings when building kernel with W=1:
Baoyou> drivers/scsi/megaraid/megaraid_sas_fusion.c:281:1: warning: no
Baoyou> previous prototype for 'megasas_free_cmds_fusion'
Baoyou> [-Wmissing-prototypes]
Baoyou> drivers/scsi/megaraid/megaraid_sas_fusion.c:714:1: warning: no
Baoyou> previous prototype for 'megasas_ioc_init_fusion'
Baoyou> [-Wmissing-prototypes] ....
Baoyou> In fact, these functions are declared in
Baoyou> drivers/scsi/megaraid/megaraid_sas_base.c, but should be
Baoyou> declared in a header file, thus can be recognized in other file.
Baoyou> So this patch adds the declarations into
Baoyou> drivers/scsi/megaraid/megaraid_sas_fusion.h.
Applied to 4.9/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-09-19 16:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-09-18 12:07 [PATCH] megaraid_sas: clean function declarations in megaraid_sas_base.c up Baoyou Xie
2016-09-19 13:50 ` Sumit Saxena
2016-09-19 16:00 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).