* [PATCH] scsi: replace wrong device handler name for CLARiiON arrays
@ 2016-10-07 16:19 Xose Vazquez Perez
2016-10-08 17:17 ` Hannes Reinecke
2016-10-11 21:58 ` Martin K. Petersen
0 siblings, 2 replies; 6+ messages in thread
From: Xose Vazquez Perez @ 2016-10-07 16:19 UTC (permalink / raw)
Cc: Xose Vazquez Perez, Christoph Hellwig, Hannes Reinecke,
Christophe Varoqui, James E . J . Bottomley, Martin K . Petersen,
SCSI ML, device-mapper development
At drivers/scsi/device_handler/scsi_dh_emc.c it was defined as:
#define CLARIION_NAME "emc"
Cc: Christoph Hellwig <hch@lst.de>
Cc: Hannes Reinecke <hare@suse.de>
Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
Cc: James E.J. Bottomley <jejb@linux.vnet.ibm.com>
Cc: Martin K. Petersen <martin.petersen@oracle.com>
Cc: SCSI ML <linux-scsi@vger.kernel.org>
Cc: device-mapper development <dm-devel@redhat.com>
Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
---
drivers/scsi/scsi_dh.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
index 54d446c..b8d3b97 100644
--- a/drivers/scsi/scsi_dh.c
+++ b/drivers/scsi/scsi_dh.c
@@ -36,9 +36,9 @@ struct scsi_dh_blist {
};
static const struct scsi_dh_blist scsi_dh_blist[] = {
- {"DGC", "RAID", "clariion" },
- {"DGC", "DISK", "clariion" },
- {"DGC", "VRAID", "clariion" },
+ {"DGC", "RAID", "emc" },
+ {"DGC", "DISK", "emc" },
+ {"DGC", "VRAID", "emc" },
{"COMPAQ", "MSA1000 VOLUME", "hp_sw" },
{"COMPAQ", "HSV110", "hp_sw" },
--
2.10.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: replace wrong device handler name for CLARiiON arrays
2016-10-07 16:19 [PATCH] scsi: replace wrong device handler name for CLARiiON arrays Xose Vazquez Perez
@ 2016-10-08 17:17 ` Hannes Reinecke
2016-10-08 23:21 ` James Bottomley
2016-10-11 21:58 ` Martin K. Petersen
1 sibling, 1 reply; 6+ messages in thread
From: Hannes Reinecke @ 2016-10-08 17:17 UTC (permalink / raw)
To: Xose Vazquez Perez
Cc: Christoph Hellwig, Christophe Varoqui, James E . J . Bottomley,
Martin K . Petersen, SCSI ML, device-mapper development
On 10/07/2016 06:19 PM, Xose Vazquez Perez wrote:
> At drivers/scsi/device_handler/scsi_dh_emc.c it was defined as:
> #define CLARIION_NAME "emc"
>
> Cc: Christoph Hellwig <hch@lst.de>
> Cc: Hannes Reinecke <hare@suse.de>
> Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> Cc: James E.J. Bottomley <jejb@linux.vnet.ibm.com>
> Cc: Martin K. Petersen <martin.petersen@oracle.com>
> Cc: SCSI ML <linux-scsi@vger.kernel.org>
> Cc: device-mapper development <dm-devel@redhat.com>
> Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> ---
> drivers/scsi/scsi_dh.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
> index 54d446c..b8d3b97 100644
> --- a/drivers/scsi/scsi_dh.c
> +++ b/drivers/scsi/scsi_dh.c
> @@ -36,9 +36,9 @@ struct scsi_dh_blist {
> };
>
> static const struct scsi_dh_blist scsi_dh_blist[] = {
> - {"DGC", "RAID", "clariion" },
> - {"DGC", "DISK", "clariion" },
> - {"DGC", "VRAID", "clariion" },
> + {"DGC", "RAID", "emc" },
> + {"DGC", "DISK", "emc" },
> + {"DGC", "VRAID", "emc" },
>
> {"COMPAQ", "MSA1000 VOLUME", "hp_sw" },
> {"COMPAQ", "HSV110", "hp_sw" },
>
Whee. Of course.
Reviewed-by: Hannes Reinecke <hare@suse.com>
Cheers,
Hannes
--
Dr. Hannes Reinecke zSeries & Storage
hare@suse.de +49 911 74053 688
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: J. Hawn, J. Guild, F. Imendörffer, HRB 16746 (AG Nürnberg)
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: replace wrong device handler name for CLARiiON arrays
2016-10-08 17:17 ` Hannes Reinecke
@ 2016-10-08 23:21 ` James Bottomley
2016-10-09 15:19 ` Christoph Hellwig
0 siblings, 1 reply; 6+ messages in thread
From: James Bottomley @ 2016-10-08 23:21 UTC (permalink / raw)
To: Hannes Reinecke, Xose Vazquez Perez
Cc: Christoph Hellwig, Christophe Varoqui, Martin K . Petersen,
SCSI ML, device-mapper development
On Sat, 2016-10-08 at 19:17 +0200, Hannes Reinecke wrote:
> On 10/07/2016 06:19 PM, Xose Vazquez Perez wrote:
> > At drivers/scsi/device_handler/scsi_dh_emc.c it was defined as:
> > #define CLARIION_NAME "emc"
> >
> > Cc: Christoph Hellwig <hch@lst.de>
> > Cc: Hannes Reinecke <hare@suse.de>
> > Cc: Christophe Varoqui <christophe.varoqui@opensvc.com>
> > Cc: James E.J. Bottomley <jejb@linux.vnet.ibm.com>
> > Cc: Martin K. Petersen <martin.petersen@oracle.com>
> > Cc: SCSI ML <linux-scsi@vger.kernel.org>
> > Cc: device-mapper development <dm-devel@redhat.com>
> > Signed-off-by: Xose Vazquez Perez <xose.vazquez@gmail.com>
> > ---
> > drivers/scsi/scsi_dh.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/scsi/scsi_dh.c b/drivers/scsi/scsi_dh.c
> > index 54d446c..b8d3b97 100644
> > --- a/drivers/scsi/scsi_dh.c
> > +++ b/drivers/scsi/scsi_dh.c
> > @@ -36,9 +36,9 @@ struct scsi_dh_blist {
> > };
> >
> > static const struct scsi_dh_blist scsi_dh_blist[] = {
> > - {"DGC", "RAID", "clariion" },
> > - {"DGC", "DISK", "clariion" },
> > - {"DGC", "VRAID", "clariion" },
> > + {"DGC", "RAID", "emc" },
> > + {"DGC", "DISK", "emc" },
> > + {"DGC", "VRAID", "emc" },
> >
> > {"COMPAQ", "MSA1000 VOLUME", "hp_sw" },
> > {"COMPAQ", "HSV110", "hp_sw" },
> >
> Whee. Of course.
>
> Reviewed-by: Hannes Reinecke <hare@suse.com>
Actually, should we replace? Aren't there older arrays still bearing
the clariion name, so we should have these entries in addition?
James
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH] scsi: replace wrong device handler name for CLARiiON arrays
2016-10-08 23:21 ` James Bottomley
@ 2016-10-09 15:19 ` Christoph Hellwig
2016-10-10 3:18 ` [dm-devel] " James Bottomley
0 siblings, 1 reply; 6+ messages in thread
From: Christoph Hellwig @ 2016-10-09 15:19 UTC (permalink / raw)
To: James Bottomley
Cc: Hannes Reinecke, Xose Vazquez Perez, Christoph Hellwig,
Christophe Varoqui, Martin K . Petersen, SCSI ML,
device-mapper development
On Sun, Oct 09, 2016 at 07:21:45AM +0800, James Bottomley wrote:
> Actually, should we replace? Aren't there older arrays still bearing
> the clariion name, so we should have these entries in addition?
The changed string isn't the inquiry vendor string, but the DH driver
name it is mapped to. And the driver for the clariion arrays is indeed
emc, even if the inquity data shows DGC.
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [dm-devel] [PATCH] scsi: replace wrong device handler name for CLARiiON arrays
2016-10-09 15:19 ` Christoph Hellwig
@ 2016-10-10 3:18 ` James Bottomley
0 siblings, 0 replies; 6+ messages in thread
From: James Bottomley @ 2016-10-10 3:18 UTC (permalink / raw)
To: Christoph Hellwig
Cc: Xose Vazquez Perez, Martin K . Petersen, SCSI ML,
device-mapper development
On Sun, 2016-10-09 at 17:19 +0200, Christoph Hellwig wrote:
> On Sun, Oct 09, 2016 at 07:21:45AM +0800, James Bottomley wrote:
> > Actually, should we replace? Aren't there older arrays still
> > bearing
> > the clariion name, so we should have these entries in addition?
>
> The changed string isn't the inquiry vendor string, but the DH driver
> name it is mapped to. And the driver for the clariion arrays is
> indeed emc, even if the inquity data shows DGC.
Ah, missed that, thanks!
Patch looks fine to me then.
James
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] scsi: replace wrong device handler name for CLARiiON arrays
2016-10-07 16:19 [PATCH] scsi: replace wrong device handler name for CLARiiON arrays Xose Vazquez Perez
2016-10-08 17:17 ` Hannes Reinecke
@ 2016-10-11 21:58 ` Martin K. Petersen
1 sibling, 0 replies; 6+ messages in thread
From: Martin K. Petersen @ 2016-10-11 21:58 UTC (permalink / raw)
To: Xose Vazquez Perez
Cc: Christoph Hellwig, Hannes Reinecke, Christophe Varoqui,
James E . J . Bottomley, Martin K . Petersen, SCSI ML,
device-mapper development
>>>>> "Xose" == Xose Vazquez Perez <xose.vazquez@gmail.com> writes:
Xose> At drivers/scsi/device_handler/scsi_dh_emc.c it was defined as:
Xose> #define CLARIION_NAME "emc"
Applied to 4.9/scsi-fixes.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-10-11 21:59 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-10-07 16:19 [PATCH] scsi: replace wrong device handler name for CLARiiON arrays Xose Vazquez Perez
2016-10-08 17:17 ` Hannes Reinecke
2016-10-08 23:21 ` James Bottomley
2016-10-09 15:19 ` Christoph Hellwig
2016-10-10 3:18 ` [dm-devel] " James Bottomley
2016-10-11 21:58 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).