From: Vivek Gautam <vivek.gautam@codeaurora.org>
To: kishon@ti.com, jejb@linux.vnet.ibm.com, vinholikatti@gmail.com,
martin.petersen@oracle.com
Cc: sboyd@codeaurora.org, subhashj@codeaurora.org,
ygardi@codeaurora.org, linux-scsi@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
Vivek Gautam <vivek.gautam@codeaurora.org>
Subject: [PATCH v5 00/12] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd
Date: Tue, 8 Nov 2016 15:37:39 +0530 [thread overview]
Message-ID: <1478599671-13071-1-git-send-email-vivek.gautam@codeaurora.org> (raw)
Hi Martin,
Here's the rebased version of patches based on 4.10/scsi-queue branch
as requested.
The patches can now be applied and pulled-in.
Thanks
These patches cleanup the ufs phy driver to an extent.
Subsequent patches will target to clean the phy_init() of
these qcom-ufs phy drivers in order to get rid of a number of
exported APIs that phy drivers expose for ufs-qcom hcd driver
to use.
These patches are based on linux-phy next branch, and have been
tested with on db820c hardware with integration branch -
'integration-linux-qcomlt' of qualcomm linaro lt tree [1].
Changes since v4:
- Rebased on top of 4.10/scsi-queue branch.
Changes since v3:
- Addressed review comment to move phy_power_off() under
*link not active* check during aggressive clock gating
from ufs hcd driver (in ufs_qcom_setup_clocks() API).
Changes since v2:
1) Addressed review comment for the patch making tx/rx_iface clocks
as optional.
Added a new compatible string for 14nm ufs phy present on msm8996
chips, and skipping the tx/r_iface clock fetching based on this
compatible string.
2) Added phy_power_off() and phy_power_on() calls in setup_clock()
callback of ufs-qcom platform driver. This is to follow the
turning off of the clocks during aggressive clock gating.
3) Addressed review comment for fixing commit message for patch:
phy: qcom-ufs-qmp-xx: Discard remove callback for drivers.
4) Added a patch to remove the call to devm_free() for resource
allocated through devm_kzalloc().
Changes since v1:
1) Added a patch to the series to remove following unnecessary
function declarations by moving the code:
- __ufs_qcom_phy_init_vreg(),
- ufs_qcom_phy_init_vreg(),
- ufs_qcom_phy_base_init()
2) Cleaned up following functions further for patch [2]:
- ufs_qcom_phy_enable(/disable)_ref_clk()
- ufs_qcom_phy_enable(/disable)_iface_clk()
3) Added patch to add phy_exit() call to ufs-qcom exit path.
4) Added a patch to remove ufs_qcom_phy_exit() from 'phy-qcom-ufs'
driver, since this api just powers off the phy.
[1] https://git.linaro.org/landing-teams/working/qualcomm/kernel.git
[2] ufs-qcom: phy/hcd: Refactoring phy clock handling
Vivek Gautam (12):
phy: qcom-ufs: Remove unnecessary BUG_ON
phy: qcom-ufs: Use devm sibling of kstrdup for regulator names
phy: qcom-ufs: Cleanup clock and regulator initialization
phy: qcom-ufs-14nm: Add new compatible for msm8996 based phy
phy: qcom-ufs: Skip obtaining rx/tx_iface_clk for msm8996 based phy
phy: qcom-ufs-qmp-xx: Discard remove callback for drivers.
phy: qcom-ufs: Remove unnecessary function declarations
phy: qcom-ufs-qmp-xx: Move clock and regulator init out of phy init
ufs-qcom: phy/hcd: Refactoring phy clock handling
phy: qcom-ufs: Remove common layer phy exit callback
scsi/ufs: qcom: Add phy_exit call in hcd exit path
scsi/ufs: qcom: Don't free resource-managed kmalloc element
Documentation/devicetree/bindings/ufs/ufs-qcom.txt | 7 +-
drivers/phy/phy-qcom-ufs-i.h | 7 +-
drivers/phy/phy-qcom-ufs-qmp-14nm.c | 72 +++---
drivers/phy/phy-qcom-ufs-qmp-20nm.c | 65 ++---
drivers/phy/phy-qcom-ufs.c | 273 +++++++++------------
drivers/scsi/ufs/ufs-qcom.c | 23 +-
include/linux/phy/phy-qcom-ufs.h | 18 --
7 files changed, 186 insertions(+), 279 deletions(-)
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
next reply other threads:[~2016-11-08 10:07 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-08 10:07 Vivek Gautam [this message]
2016-11-08 10:07 ` [PATCH v5 01/12] phy: qcom-ufs: Remove unnecessary BUG_ON Vivek Gautam
2016-11-08 10:07 ` [PATCH v5 02/12] phy: qcom-ufs: Use devm sibling of kstrdup for regulator names Vivek Gautam
2016-11-08 10:07 ` [PATCH v5 03/12] phy: qcom-ufs: Cleanup clock and regulator initialization Vivek Gautam
2016-11-08 10:07 ` [PATCH v5 04/12] phy: qcom-ufs-14nm: Add new compatible for msm8996 based phy Vivek Gautam
2016-11-08 10:07 ` [PATCH v5 05/12] phy: qcom-ufs: Skip obtaining rx/tx_iface_clk " Vivek Gautam
2016-11-08 10:07 ` [PATCH v5 06/12] phy: qcom-ufs-qmp-xx: Discard remove callback for drivers Vivek Gautam
2016-11-08 10:07 ` [PATCH v5 07/12] phy: qcom-ufs: Remove unnecessary function declarations Vivek Gautam
2016-11-08 10:07 ` [PATCH v5 08/12] phy: qcom-ufs-qmp-xx: Move clock and regulator init out of phy init Vivek Gautam
2016-11-08 10:07 ` [PATCH v5 09/12] ufs-qcom: phy/hcd: Refactoring phy clock handling Vivek Gautam
2016-11-08 10:07 ` [PATCH v5 10/12] phy: qcom-ufs: Remove common layer phy exit callback Vivek Gautam
2016-11-08 10:07 ` [PATCH v5 11/12] scsi/ufs: qcom: Add phy_exit call in hcd exit path Vivek Gautam
2016-11-08 10:07 ` [PATCH v5 12/12] scsi/ufs: qcom: Don't free resource-managed kmalloc element Vivek Gautam
2016-11-08 23:06 ` [PATCH v5 00/12] ufs-qcom: phy/hcd: Clean up qcom-ufs phy and ufs-qcom hcd Martin K. Petersen
2016-11-09 5:16 ` Vivek Gautam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1478599671-13071-1-git-send-email-vivek.gautam@codeaurora.org \
--to=vivek.gautam@codeaurora.org \
--cc=jejb@linux.vnet.ibm.com \
--cc=kishon@ti.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=sboyd@codeaurora.org \
--cc=subhashj@codeaurora.org \
--cc=vinholikatti@gmail.com \
--cc=ygardi@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).