From: Martin Wilck <mwilck@suse.de>
To: Johannes Thumshirn <jthumshirn@suse.de>, martin.petersen@oracle.com
Cc: don.brace@pmcs.com, storagedev@pmcs.com,
linux-scsi@vger.kernel.org, jejb@linux.vnet.ibm.com, hch@lst.de,
hare@suse.de
Subject: Re: [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading
Date: Mon, 21 Nov 2016 16:13:26 +0100 [thread overview]
Message-ID: <1479741206.25031.27.camel@suse.de> (raw)
In-Reply-To: <20161121141336.gkc35pjmlojhxm35@linux-x5ow.site>
On Mon, 2016-11-21 at 15:13 +0100, Johannes Thumshirn wrote:
> On Mon, Nov 21, 2016 at 03:04:28PM +0100, Martin Wilck wrote:
> > When the hpsa module is unloaded using rmmod, dangling
> > symlinks remain under /sys/class/sas_phy. Fix this by
> > calling sas_phy_delete() rather than sas_phy_free (which,
> > according to comments, should not be called for PHYs that
> > have been set up successfully, anyway).
> >
> > References: bsc#1010946.
>
> I don't think the SUSE bugzilla tag is of relevance upstream. But for
> sake of
> completeness we could add a
> Link: https://bugzilla.suse.com/show_bug.cgi?id=1010946
I am sorry for this mistake.
@Martin, do you want me to re-submit with these references fixed?
I also apologize for the broken cc list of the first series, I hope I
got it right this time.
Regards
Martin
>
> > Signed-off-by: Martin Wilck <mwilck@suse.de>
>
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
next prev parent reply other threads:[~2016-11-21 15:13 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-21 14:04 [PATCH 0/2] hpsa: fix rmmod issues Martin Wilck
2016-11-21 14:04 ` [PATCH 1/2] hpsa: cleanup sas_phy structures in sysfs when unloading Martin Wilck
2016-11-21 14:13 ` Johannes Thumshirn
2016-11-21 15:13 ` Martin Wilck [this message]
2016-11-22 3:47 ` Martin K. Petersen
2016-11-22 8:10 ` Johannes Thumshirn
2016-11-29 1:52 ` Don Brace
2016-11-29 9:16 ` Martin Wilck
2016-11-21 14:04 ` [PATCH 2/2] hpsa: destroy sas transport properties before scsi_host Martin Wilck
2016-11-21 14:14 ` Johannes Thumshirn
2017-10-10 23:04 ` Don Brace
2017-10-11 9:15 ` Martin Wilck
2016-12-01 23:22 ` [PATCH 0/2] hpsa: fix rmmod issues Don Brace
2016-12-02 8:58 ` Martin Wilck
2016-12-02 15:44 ` Don Brace
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479741206.25031.27.camel@suse.de \
--to=mwilck@suse.de \
--cc=don.brace@pmcs.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=jejb@linux.vnet.ibm.com \
--cc=jthumshirn@suse.de \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=storagedev@pmcs.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).