From: "Ewan D. Milne" <emilne@redhat.com>
To: dgilbert@interlog.com
Cc: Eyal Ben David <bdeyal@gmail.com>,
Laurence Oberman <loberman@redhat.com>,
linux-scsi@vger.kernel.org
Subject: Re: SG does not ignore dxferp (direct io + mmap)
Date: Mon, 21 Nov 2016 13:24:02 -0500 [thread overview]
Message-ID: <1479752642.19792.43.camel@localhost.localdomain> (raw)
In-Reply-To: <1ca8515f-abd2-7428-8baa-dca879833be3@interlog.com>
On Mon, 2016-11-21 at 12:34 -0500, Douglas Gilbert wrote:
> There was also this change which seems closer to the problem area:
>
> commit 461c7fa126794157484dca48e88effa4963e3af3
> Author: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
> Date: Tue Feb 2 16:57:35 2016 -0800
>
> drivers/scsi/sg.c: mark VMA as VM_IO to prevent migration
> ...
>
> diff --git a/drivers/scsi/sg.c b/drivers/scsi/sg.c
> index 503ab8b..5e82067 100644
> --- a/drivers/scsi/sg.c
> +++ b/drivers/scsi/sg.c
> @@ -1261,7 +1261,7 @@ sg_mmap(struct file *filp, struct vm_area_struct *vma)
> }
>
> sfp->mmap_called = 1;
> - vma->vm_flags |= VM_DONTEXPAND | VM_DONTDUMP;
> + vma->vm_flags |= VM_IO | VM_DONTEXPAND | VM_DONTDUMP;
> vma->vm_private_data = sfp;
> vma->vm_ops = &sg_mmap_vm_ops;
> return 0;
>
> Doug Gilbert
>
Neither this change nor "sg: fix dxferp in from_to case" appears to
fix the issue when applied on top of 4.4. Still looking...
-Ewan
next prev parent reply other threads:[~2016-11-21 18:24 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-20 16:02 SG does not ignore dxferp (direct io + mmap) Eyal Ben David
2016-11-21 0:04 ` Laurence Oberman
2016-11-21 9:23 ` Eyal Ben David
2016-11-21 14:24 ` Ewan D. Milne
2016-11-21 14:54 ` Laurence Oberman
2016-11-21 14:55 ` Eyal Ben David
2016-11-21 15:12 ` Laurence Oberman
2016-11-21 15:15 ` Johannes Thumshirn
2016-11-21 15:44 ` Johannes Thumshirn
2016-11-21 16:04 ` Eyal Ben David
2016-11-21 16:25 ` Ewan D. Milne
2016-11-21 17:34 ` Douglas Gilbert
2016-11-21 18:24 ` Ewan D. Milne [this message]
2016-11-22 8:37 ` Johannes Thumshirn
2016-11-22 13:48 ` Eyal Ben David
2016-11-22 15:31 ` Laurence Oberman
2016-11-22 16:00 ` Johannes Thumshirn
2016-11-22 16:28 ` Eyal Ben David
2016-11-22 18:30 ` Ewan D. Milne
2016-11-22 18:46 ` Laurence Oberman
2016-11-22 20:55 ` Eyal Ben David
2016-11-23 18:55 ` Laurence Oberman
2016-11-23 20:22 ` Ewan D. Milne
2016-11-25 8:07 ` Johannes Thumshirn
2016-11-25 11:20 ` Eyal Ben David
2016-11-25 11:53 ` Johannes Thumshirn
2016-11-25 12:28 ` Johannes Thumshirn
2016-11-25 12:36 ` Eyal Ben David
2016-11-25 14:46 ` Laurence Oberman
2016-11-28 10:30 ` Johannes Thumshirn
2016-11-25 17:56 ` Ewan Milne
2016-11-25 18:01 ` Laurence Oberman
2016-11-30 16:26 ` Ewan D. Milne
2016-12-01 13:40 ` Martin K. Petersen
2016-12-02 12:21 ` Christoph Hellwig
2016-12-02 13:29 ` Ewan D. Milne
2016-12-02 14:10 ` Hannes Reinecke
2016-12-02 14:17 ` Laurence Oberman
2016-12-02 19:29 ` Ewan D. Milne
2016-12-02 20:37 ` Ewan D. Milne
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1479752642.19792.43.camel@localhost.localdomain \
--to=emilne@redhat.com \
--cc=bdeyal@gmail.com \
--cc=dgilbert@interlog.com \
--cc=linux-scsi@vger.kernel.org \
--cc=loberman@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).