From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hch@infradead.org" <hch@infradead.org>,
"himanshu.madhani@cavium.com" <himanshu.madhani@cavium.com>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"giridhar.malavali@cavium.com" <giridhar.malavali@cavium.com>
Subject: Re: [PATCH v2 02/10] qla2xxx: Include ATIO queue in firmware dump when in target mode
Date: Fri, 23 Dec 2016 08:32:31 +0000 [thread overview]
Message-ID: <1482481930.3510.2.camel@sandisk.com> (raw)
In-Reply-To: <1482357459-31079-3-git-send-email-himanshu.madhani@cavium.com>
On Wed, 2016-12-21 at 13:57 -0800, Himanshu Madhani wrote:
> @@ -676,6 +688,18 @@ static inline void (*qla27xx_read_vector(uint width))(void __iomem*, void *, ulo
> count++;
> }
> }
> + } else if (QLA_TGT_MODE_ENABLED() &&
> + ent->t274.queue_type == T274_QUEUE_TYPE_ATIO_SHAD) {
> + struct qla_hw_data *ha = vha->hw;
> + struct atio *atr = ha->tgt.atio_ring_ptr;
> +
> + if (atr || !buf) {
> + qla27xx_insert16(0, buf, len);
> + qla27xx_insert16(1, buf, len);
> + qla27xx_insert32(ha->tgt.atio_q_in ?
> + *ha->tgt.atio_q_in : 0, buf, len);
> + count++;
> + }
> } else {
> ql_dbg(ql_dbg_misc, vha, 0xd02f,
> "%s: unknown queue %x\n", __func__, ent->t274.queue_type);
Hello Himanshu,
This patch introduces a new sparse warning for *ha->tgt.atio_q_in:
drivers/scsi/qla2xxx/qla_tmpl.c:700:37: warning: dereference of noderef expression
Sparse reports this because the atio_q_in pointer is declared as uint32_t __iomem*.
Does this perhaps mean that a readl() call is missing?
Bart.
next prev parent reply other threads:[~2016-12-23 8:32 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-21 21:57 [PATCH v2 00/10] qla2xxx: Bug fixes for driver Himanshu Madhani
2016-12-21 21:57 ` [PATCH v2 01/10] qla2xxx: Fix wrong IOCB type assumption Himanshu Madhani
2016-12-21 21:57 ` [PATCH v2 02/10] qla2xxx: Include ATIO queue in firmware dump when in target mode Himanshu Madhani
2016-12-23 8:32 ` Bart Van Assche [this message]
2016-12-24 0:37 ` Madhani, Himanshu
2016-12-21 21:57 ` [PATCH v2 03/10] qla2xxx: Set tcm_qla2xxx version to automatically track qla2xxx version Himanshu Madhani
2016-12-21 21:57 ` [PATCH v2 04/10] qla2xxx: Reset reserved field in firmware options to 0 Himanshu Madhani
2016-12-23 8:37 ` Bart Van Assche
2016-12-24 0:07 ` Madhani, Himanshu
2016-12-21 21:57 ` [PATCH v2 05/10] qla2xxx: Collect additional information to debug fw dump Himanshu Madhani
2016-12-21 21:57 ` [PATCH v2 06/10] qla2xxx: Fix crash due to null pointer access Himanshu Madhani
2016-12-23 8:47 ` Bart Van Assche
2016-12-24 0:06 ` Madhani, Himanshu
2016-12-21 21:57 ` [PATCH v2 07/10] qla2xxx: Terminate exchange if corrputed Himanshu Madhani
2016-12-23 9:01 ` Bart Van Assche
2016-12-23 23:55 ` Madhani, Himanshu
2016-12-21 21:57 ` [PATCH v2 08/10] qla2xxx: Reduce exess wait during chip reset Himanshu Madhani
2016-12-21 21:57 ` [PATCH v2 09/10] qla2xxx: Fix invalid handle erroneous message Himanshu Madhani
2016-12-21 21:57 ` [PATCH v2 10/10] qla2xxx: Disable Out-of-order processing by default in Firmware Himanshu Madhani
2016-12-22 9:25 ` [PATCH v2 00/10] qla2xxx: Bug fixes for driver Christoph Hellwig
2016-12-22 16:44 ` Madhani, Himanshu
2016-12-22 17:02 ` Bart Van Assche
2016-12-22 17:27 ` Madhani, Himanshu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1482481930.3510.2.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=giridhar.malavali@cavium.com \
--cc=hch@infradead.org \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).