* [PATCH] scsi: lpfc: Replace BUG() with BUG_ON()
@ 2016-12-24 10:51 Shyam Saini
2017-01-17 20:34 ` James Smart
2017-01-20 21:49 ` Martin K. Petersen
0 siblings, 2 replies; 3+ messages in thread
From: Shyam Saini @ 2016-12-24 10:51 UTC (permalink / raw)
To: james.smart; +Cc: dick.kennedy, jejb, martin.petersen, linux-scsi, Shyam Saini
Replace BUG() with BUG_ON() using coccinelle
Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
---
drivers/scsi/lpfc/lpfc_els.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
index 27f0cbb..ede14f1 100644
--- a/drivers/scsi/lpfc/lpfc_els.c
+++ b/drivers/scsi/lpfc/lpfc_els.c
@@ -8855,8 +8855,7 @@ lpfc_cmpl_fabric_iocb(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
{
struct ls_rjt stat;
- if ((cmdiocb->iocb_flag & LPFC_IO_FABRIC) != LPFC_IO_FABRIC)
- BUG();
+ BUG_ON((cmdiocb->iocb_flag & LPFC_IO_FABRIC) != LPFC_IO_FABRIC);
switch (rspiocb->iocb.ulpStatus) {
case IOSTAT_NPORT_RJT:
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: lpfc: Replace BUG() with BUG_ON()
2016-12-24 10:51 [PATCH] scsi: lpfc: Replace BUG() with BUG_ON() Shyam Saini
@ 2017-01-17 20:34 ` James Smart
2017-01-20 21:49 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: James Smart @ 2017-01-17 20:34 UTC (permalink / raw)
To: Shyam Saini; +Cc: dick.kennedy, jejb, martin.petersen, linux-scsi
Good by me.
-- james
Signed-off-by: James Smart <james.smart@broadcom.com>
On 12/24/2016 2:51 AM, Shyam Saini wrote:
> Replace BUG() with BUG_ON() using coccinelle
>
> Signed-off-by: Shyam Saini <mayhs11saini@gmail.com>
> ---
> drivers/scsi/lpfc/lpfc_els.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/lpfc/lpfc_els.c b/drivers/scsi/lpfc/lpfc_els.c
> index 27f0cbb..ede14f1 100644
> --- a/drivers/scsi/lpfc/lpfc_els.c
> +++ b/drivers/scsi/lpfc/lpfc_els.c
> @@ -8855,8 +8855,7 @@ lpfc_cmpl_fabric_iocb(struct lpfc_hba *phba, struct lpfc_iocbq *cmdiocb,
> {
> struct ls_rjt stat;
>
> - if ((cmdiocb->iocb_flag & LPFC_IO_FABRIC) != LPFC_IO_FABRIC)
> - BUG();
> + BUG_ON((cmdiocb->iocb_flag & LPFC_IO_FABRIC) != LPFC_IO_FABRIC);
>
> switch (rspiocb->iocb.ulpStatus) {
> case IOSTAT_NPORT_RJT:
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] scsi: lpfc: Replace BUG() with BUG_ON()
2016-12-24 10:51 [PATCH] scsi: lpfc: Replace BUG() with BUG_ON() Shyam Saini
2017-01-17 20:34 ` James Smart
@ 2017-01-20 21:49 ` Martin K. Petersen
1 sibling, 0 replies; 3+ messages in thread
From: Martin K. Petersen @ 2017-01-20 21:49 UTC (permalink / raw)
To: Shyam Saini; +Cc: james.smart, dick.kennedy, jejb, martin.petersen, linux-scsi
>>>>> "Shyam" == Shyam Saini <mayhs11saini@gmail.com> writes:
Shyam> Replace BUG() with BUG_ON() using coccinelle
Applied to 4.11/scsi-queue.
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-20 21:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-12-24 10:51 [PATCH] scsi: lpfc: Replace BUG() with BUG_ON() Shyam Saini
2017-01-17 20:34 ` James Smart
2017-01-20 21:49 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).