From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Ewan D. Milne" Subject: Re: [PATCH] scsi: qedi: select UIO Date: Tue, 10 Jan 2017 15:19:34 -0500 Message-ID: <1484079574.15161.91.camel@localhost.localdomain> References: <20170110152744.3139180-1-arnd@arndb.de> Reply-To: emilne@redhat.com Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170110152744.3139180-1-arnd@arndb.de> Sender: linux-kernel-owner@vger.kernel.org To: Arnd Bergmann Cc: "James E.J. Bottomley" , "Martin K. Petersen" , QLogic-Storage-Upstream@cavium.com, Johannes Thumshirn , Nilesh Javali , Adheer Chandravanshi , Manish Rangankar , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-scsi@vger.kernel.org On Tue, 2017-01-10 at 16:27 +0100, Arnd Bergmann wrote: > The newly added qedi driver links against the UIO framework, but can > be built without that: > > drivers/scsi/qedi/qedi_main.o: In function `qedi_free_uio': > qedi_main.c:(.text.qedi_free_uio+0x78): undefined reference to `uio_unregister_device' > drivers/scsi/qedi/qedi_main.o: In function `qedi_ll2_recv_thread': > qedi_main.c:(.text.qedi_ll2_recv_thread+0x18c): undefined reference to `uio_event_notify' > drivers/scsi/qedi/qedi_main.o: In function `__qedi_probe.constprop.1': > qedi_main.c:(.text.__qedi_probe.constprop.1+0x1368): undefined reference to `__uio_register_device' > > This adds a compile-time dependency. > > Fixes: ace7f46ba5fd ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.") > Signed-off-by: Arnd Bergmann > --- > drivers/scsi/qedi/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/qedi/Kconfig b/drivers/scsi/qedi/Kconfig > index 23ca8a274586..913610f3d274 100644 > --- a/drivers/scsi/qedi/Kconfig > +++ b/drivers/scsi/qedi/Kconfig > @@ -2,6 +2,7 @@ config QEDI > tristate "QLogic QEDI 25/40/100Gb iSCSI Initiator Driver Support" > depends on PCI && SCSI > depends on QED > + depends on UIO > select SCSI_ISCSI_ATTRS > select QED_LL2 > select QED_ISCSI Randy posted a similar patch back in December but I don't think there was ever a reply to Christoph's question about why qedi depends on uio. -Ewan