From mboxrd@z Thu Jan 1 00:00:00 1970 From: James Bottomley Subject: Re: Advanced Format SAT devices show incorrect physical block size Date: Tue, 10 Jan 2017 14:12:25 -0800 Message-ID: <1484086345.2518.9.camel@HansenPartnership.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: Sender: linux-usb-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Alan Stern , Dainius =?UTF-8?Q?Masili=C5=ABnas?= Cc: Pali =?ISO-8859-1?Q?Roh=E1r?= , SCSI development list , USB list , Tom Yan List-Id: linux-scsi@vger.kernel.org On Tue, 2017-01-10 at 16:00 -0500, Alan Stern wrote: > In theory, I suppose we could change the kernel so that it would > default to READ CAPACITY(16) for devices that report a SCSI level >= > 3, or something along those lines. In general we hesitate to make > changes of this sort, because they almost always end up breaking > _some_ devices -- and if that happens then the change is reverted, > with no exceptions. Linus has a very strict rule about not breaking > working systems. You shouldn't have to change anything: it already does (otherwise how else would we detect physical exponent for proper SCSI devices) see sd.c:sd_try_rc16_first(). It always returns false for USB because you set sdev->try_rc_10_first James -- To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html