From: James Bottomley <James.Bottomley@HansenPartnership.com>
To: "Ewan D. Milne" <emilne@redhat.com>, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] ses: Fix SAS device detection in enclosure
Date: Tue, 17 Jan 2017 06:47:54 -0800 [thread overview]
Message-ID: <1484664474.2433.24.camel@HansenPartnership.com> (raw)
In-Reply-To: <1483997616-18900-1-git-send-email-emilne@redhat.com>
On Mon, 2017-01-09 at 16:33 -0500, Ewan D. Milne wrote:
> From: "Ewan D. Milne" <emilne@redhat.com>
>
> The call to scsi_is_sas_rphy() needs to be made on the
> SAS end_device, not on the SCSI device.
>
> Fixes: 835831c57e9b ("ses: use scsi_is_sas_rphy instead of
> is_sas_attached")
> Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>
> Signed-off-by: Ewan D. Milne <emilne@redhat.com>
Yes, looks good to me as well
Reviewed-by: James Bottomley <James.Bottomley@HansenPartnership.com>
next prev parent reply other threads:[~2017-01-17 14:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-09 21:33 [PATCH] ses: Fix SAS device detection in enclosure Ewan D. Milne
2017-01-16 21:02 ` Martin K. Petersen
2017-01-17 7:56 ` Johannes Thumshirn
2017-01-17 14:47 ` James Bottomley [this message]
2017-01-17 19:02 ` Martin K. Petersen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484664474.2433.24.camel@HansenPartnership.com \
--to=james.bottomley@hansenpartnership.com \
--cc=emilne@redhat.com \
--cc=linux-scsi@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox