From: Bart Van Assche <Bart.VanAssche@sandisk.com>
To: "hch@infradead.org" <hch@infradead.org>,
"himanshu.madhani@cavium.com" <himanshu.madhani@cavium.com>,
"target-devel@vger.kernel.org" <target-devel@vger.kernel.org>,
"nab@linux-iscsi.org" <nab@linux-iscsi.org>
Cc: "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
"giridhar.malavali@cavium.com" <giridhar.malavali@cavium.com>
Subject: Re: [PATCH v3 00/12] qla2xxx: Feature updates for target.
Date: Thu, 19 Jan 2017 23:03:09 +0000 [thread overview]
Message-ID: <1484866972.2634.10.camel@sandisk.com> (raw)
In-Reply-To: <1484781585-27252-1-git-send-email-himanshu.madhani@cavium.com>
On Wed, 2017-01-18 at 15:19 -0800, Himanshu Madhani wrote:
> Changes from v2 --> v3
>
> o Cleaned up sparse warnings reported by you.
Not all warnings have been addressed. I still see the following smatch
warnings:
CHECK drivers/scsi/qla2xxx/qla_init.c
drivers/scsi/qla2xxx/qla_init.c:265: qla2x00_async_logout() error: we previously assumed 'sp' could be null (see line 241)
CHECK drivers/scsi/qla2xxx/qla_isr.c
drivers/scsi/qla2xxx/qla_isr.c:1456: qla2x00_ct_entry() warn: inconsistent indenting
The second warning is minor but is easy to address. The first one is
serious and applies to the following code: if (!sp) ... sp->....
Please address these smatch warnings.
Thanks,
Bart.
prev parent reply other threads:[~2017-01-19 23:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-18 23:19 [PATCH v3 00/12] qla2xxx: Feature updates for target Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 01/12] qla2xxx: Remove direct access of scsi_status field in se_cmd Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 02/12] qla2xxx: Cleanup TMF code translation from qla_target Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 03/12] qla2xxx: Make trace flags more readable Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 04/12] qla2xxx: Remove SRR code Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 05/12] qla2xxx: Fix wrong argument in sp done callback Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 06/12] qla2xxx: Use d_id instead of s_id for more clarity Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 07/12] qla2xxx: Track I-T nexus as single fc_port struct Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 08/12] qla2xxx: Add framework for Async fabric discovery Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 09/12] qla2xxx: Add Dual mode support in the driver Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 10/12] qla2xxx: Remove unused reverse_ini_mode Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 11/12] qla2xxx: Improve RSCN handling in driver Himanshu Madhani
2017-01-18 23:19 ` [PATCH v3 12/12] qla2xxx: Simplify usage of SRB structure " Himanshu Madhani
2017-01-19 23:03 ` Bart Van Assche [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1484866972.2634.10.camel@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=giridhar.malavali@cavium.com \
--cc=hch@infradead.org \
--cc=himanshu.madhani@cavium.com \
--cc=linux-scsi@vger.kernel.org \
--cc=nab@linux-iscsi.org \
--cc=target-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).